Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Side by Side Diff: chrome/android/java/res/values-v17/styles.xml

Issue 1702003004: Replace update menu badge (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@2623
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/android/java/res/layout/toolbar.xml ('k') | chrome/android/java/res/values/dimens.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <resources xmlns:tools="http://schemas.android.com/tools"> 6 <resources xmlns:tools="http://schemas.android.com/tools">
7 <!-- Q: Why put style resources under values-v17/ ? 7 <!-- Q: Why put style resources under values-v17/ ?
8 A: Problem: 8 A: Problem:
9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339. 9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339.
10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert 10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert
(...skipping 457 matching lines...) Expand 10 before | Expand all | Expand 10 after
468 <item name="android:windowEnterAnimation">@anim/snackbar_in</item> 468 <item name="android:windowEnterAnimation">@anim/snackbar_in</item>
469 <item name="android:windowExitAnimation">@anim/snackbar_out</item> 469 <item name="android:windowExitAnimation">@anim/snackbar_out</item>
470 </style> 470 </style>
471 <style name="SnackbarAnimationWithKeyboard"> 471 <style name="SnackbarAnimationWithKeyboard">
472 <item name="android:windowEnterAnimation">@anim/snackbar_in_with_keyboar d</item> 472 <item name="android:windowEnterAnimation">@anim/snackbar_in_with_keyboar d</item>
473 <item name="android:windowExitAnimation">@anim/snackbar_out</item> 473 <item name="android:windowExitAnimation">@anim/snackbar_out</item>
474 </style> 474 </style>
475 <style name="LocationBarButton"> 475 <style name="LocationBarButton">
476 <item name="android:background">@null</item> 476 <item name="android:background">@null</item>
477 </style> 477 </style>
478 <style name="LocationBarMenuButton" parent="LocationBarButton">
479 <item name="android:layout_height">match_parent</item>
480 <item name="android:layout_width">match_parent</item>
481 </style>
478 <style name="ToolbarButton"> 482 <style name="ToolbarButton">
479 <item name="android:background">?attr/selectableItemBackground</item> 483 <item name="android:background">?attr/selectableItemBackground</item>
480 <item name="android:layout_width">48dp</item> 484 <item name="android:layout_width">48dp</item>
481 <item name="android:layout_height">56dp</item> 485 <item name="android:layout_height">56dp</item>
482 <item name="android:scaleType">center</item> 486 <item name="android:scaleType">center</item>
483 </style> 487 </style>
488 <style name="ToolbarMenuButtonPhone" parent="ToolbarButton">
489 <item name="android:layout_gravity">top</item>
490 <item name="android:layout_width">42dp</item>
491 <item name="android:paddingEnd">4dp</item>
492 <item name="android:background">@null</item>
493 </style>
494 <style name="ToolbarMenuButtonTablet" parent="ToolbarButton">
495 <item name="android:layout_width">43dp</item>
496 <item name="android:paddingEnd">3.5dp</item>
497 </style>
484 <style name="AppMenuItem"> 498 <style name="AppMenuItem">
485 <item name="android:paddingStart">16dp</item> 499 <item name="android:paddingStart">16dp</item>
486 <item name="android:paddingEnd">16dp</item> 500 <item name="android:paddingEnd">16dp</item>
487 <item name="android:background">?attr/listChoiceBackgroundIndicator</ite m> 501 <item name="android:background">?attr/listChoiceBackgroundIndicator</ite m>
488 </style> 502 </style>
489 <style name="UpdateMenuBadge">
490 <item name="android:layout_height">@dimen/menu_badge_size</item>
491 <item name="android:layout_width">@dimen/menu_badge_size</item>
492 <item name="android:layout_gravity">end|bottom</item>
493 <item name="android:layout_marginBottom">14dp</item>
494 <item name="android:focusable">false</item>
495 <item name="android:importantForAccessibility">no</item>
496 <item name="android:visibility">invisible</item>
497 </style>
498 </resources> 503 </resources>
OLDNEW
« no previous file with comments | « chrome/android/java/res/layout/toolbar.xml ('k') | chrome/android/java/res/values/dimens.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698