Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 1702003004: Replace update menu badge (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@2623
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
index c9611c552300ea149e701e6aed87b0e977977590..57b5139e8dbdf5c1f0cf7d18a569258d27979137 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
@@ -361,6 +361,16 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
mAppMenuHandler.addObserver(new AppMenuObserver() {
@Override
public void onMenuVisibilityChanged(boolean isVisible) {
+ if (isVisible && !isInOverviewMode()) {
+ // The app menu badge should be removed the first time the menu is opened.
+ if (mToolbarManager.getToolbar().isShowingAppMenuUpdateBadge()) {
+ mToolbarManager.getToolbar().removeAppMenuUpdateBadge(true);
+
+ // TODO(twellington): Try invalidating the toolbar instead of requesting
+ // render. See crbug.com/585975.
+ mCompositorViewHolder.requestRender();
+ }
+ }
if (!isVisible) {
mAppMenuPropertiesDelegate.onMenuDismissed();
MenuItem updateMenuItem = mAppMenuHandler.getAppMenu().getMenu().findItem(
@@ -1306,7 +1316,7 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
mToolbarManager.getToolbar().showAppMenuUpdateBadge();
mCompositorViewHolder.requestRender();
} else {
- mToolbarManager.getToolbar().removeAppMenuUpdateBadge();
+ mToolbarManager.getToolbar().removeAppMenuUpdateBadge(false);
}
}

Powered by Google App Engine
This is Rietveld 408576698