Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1070)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 169893003: Another round of cleanups for http://www.dartbug.com/15922 (Closed)

Created:
6 years, 10 months ago by Ivan Posva
Modified:
6 years, 10 months ago
Reviewers:
Anders Johnsen, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Another round of cleanups for http://www.dartbug.com/15922 - Address warnings about 64-bit to 32-bit conversions. R=ajohnsen@google.com, asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=32831

Patch Set 1 #

Total comments: 9
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -59 lines) Patch
M runtime/bin/builtin_impl_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/dbg_message.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M runtime/bin/file.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/file_macos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/process_macos.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/signal_blocker.h View 1 chunk +3 lines, -3 lines 2 comments Download
M runtime/lib/mirrors.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M runtime/lib/object.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/string.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M runtime/platform/globals.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/platform/utils.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/platform/utils.cc View 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/ast_printer.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/native_arguments.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/object.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M runtime/vm/snapshot.h View 4 chunks +5 lines, -5 lines 3 comments Download
M runtime/vm/snapshot.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/unicode.h View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/issue14236_source.dart View 1 chunk +4 lines, -2 lines 4 comments Download
M tests/standalone/issue14236_test.dart View Binary file 0 comments Download
M tests/standalone/standalone.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Ivan Posva
This should fix all of the VM related issues on ia32. The only outstanding failures ...
6 years, 10 months ago (2014-02-17 23:03:28 UTC) #1
Anders Johnsen
lgtm https://codereview.chromium.org/169893003/diff/1/runtime/vm/snapshot.h File runtime/vm/snapshot.h (right): https://codereview.chromium.org/169893003/diff/1/runtime/vm/snapshot.h#newcode132 runtime/vm/snapshot.h:132: static const int kHeaderSize = 2 * sizeof(int64_t); ...
6 years, 10 months ago (2014-02-18 10:02:33 UTC) #2
siva
lgtm https://codereview.chromium.org/169893003/diff/1/runtime/bin/signal_blocker.h File runtime/bin/signal_blocker.h (right): https://codereview.chromium.org/169893003/diff/1/runtime/bin/signal_blocker.h#newcode66 runtime/bin/signal_blocker.h:66: (static_cast<void>(TEMP_FAILURE_RETRY_BLOCK_SIGNALS(expression))) Maybe in another CL we should consider ...
6 years, 10 months ago (2014-02-19 00:34:04 UTC) #3
siva
lgtm
6 years, 10 months ago (2014-02-19 00:34:05 UTC) #4
Ivan Posva
https://codereview.chromium.org/169893003/diff/1/runtime/bin/signal_blocker.h File runtime/bin/signal_blocker.h (right): https://codereview.chromium.org/169893003/diff/1/runtime/bin/signal_blocker.h#newcode66 runtime/bin/signal_blocker.h:66: (static_cast<void>(TEMP_FAILURE_RETRY_BLOCK_SIGNALS(expression))) On 2014/02/19 00:34:04, siva wrote: > Maybe in ...
6 years, 10 months ago (2014-02-19 04:04:23 UTC) #5
siva
https://codereview.chromium.org/169893003/diff/1/tests/standalone/issue14236_source.dart File tests/standalone/issue14236_source.dart (right): https://codereview.chromium.org/169893003/diff/1/tests/standalone/issue14236_source.dart#newcode16 tests/standalone/issue14236_source.dart:16: // 2) $ ./xcodebuild/DebugIA32/dart --package-root=./xcodebuild/DebugIA32/packages --snapshot=tests/standalone/issue14236_new_test.dart tests/standalone/issue14236_source.dart One more ...
6 years, 10 months ago (2014-02-19 06:01:19 UTC) #6
Ivan Posva
6 years, 10 months ago (2014-02-19 23:36:05 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 manually as r32831 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698