Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: runtime/vm/object.cc

Issue 169893003: Another round of cleanups for http://www.dartbug.com/15922 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object.cc
===================================================================
--- runtime/vm/object.cc (revision 32732)
+++ runtime/vm/object.cc (working copy)
@@ -5108,9 +5108,9 @@
}
return false; // Too many named arguments.
}
- const int num_pos_args = num_arguments - num_named_arguments;
- const int num_opt_pos_params = NumOptionalPositionalParameters();
- const int num_pos_params = num_fixed_parameters() + num_opt_pos_params;
+ const intptr_t num_pos_args = num_arguments - num_named_arguments;
+ const intptr_t num_opt_pos_params = NumOptionalPositionalParameters();
+ const intptr_t num_pos_params = num_fixed_parameters() + num_opt_pos_params;
if (num_pos_args > num_pos_params) {
if (error_message != NULL) {
const intptr_t kMessageBufferSize = 64;
@@ -11979,7 +11979,7 @@
}
-bool Instance::IsValidFieldOffset(int offset) const {
+bool Instance::IsValidFieldOffset(intptr_t offset) const {
const Class& cls = Class::Handle(clazz());
return (offset >= 0 && offset <= (cls.instance_size() - kWordSize));
}
@@ -16218,7 +16218,9 @@
}
-RawArray* Array::Grow(const Array& source, int new_length, Heap::Space space) {
+RawArray* Array::Grow(const Array& source,
+ intptr_t new_length,
+ Heap::Space space) {
const Array& result = Array::Handle(Array::New(new_length, space));
intptr_t len = 0;
if (!source.IsNull()) {

Powered by Google App Engine
This is Rietveld 408576698