Another round of cleanups for http://www.dartbug.com/15922

runtime/lib/mirrors.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "lib/invocation_mirror.h"
 #include "vm/bootstrap_natives.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart_entry.h"
 #include "vm/exceptions.h"
@@ skipping 64 matching lines @@
 
   const Array& args = Array::Handle(Array::New(6));
   args.SetAt(0, receiver);
   args.SetAt(1, function_name);
   args.SetAt(2, invocation_type);
   // Parameter 3 (actual arguments): We omit this parameter to get the same
   // error message as one would get by invoking the function non-reflectively.
   // Parameter 4 (named arguments): We omit this parameters since we cannot
   // invoke functions with named parameters reflectively (using mirrors).
   if (!function.IsNull()) {
-    const int total_num_parameters = function.NumParameters();
+    const intptr_t total_num_parameters = function.NumParameters();
     const Array& array = Array::Handle(Array::New(total_num_parameters));
     String& param_name = String::Handle();
     for (int i = 0; i < total_num_parameters; i++) {
       param_name = function.ParameterNameAt(i);
       array.SetAt(i, param_name);
     }
     args.SetAt(5, array);
   }
 
   Exceptions::ThrowByType(Exceptions::kNoSuchMethod, args);
@@ skipping 330 matching lines @@
   args.SetAt(1, root_library_mirror);
   return CreateMirror(Symbols::_LocalIsolateMirror(), args);
 }
 
 
 static RawInstance* CreateMirrorSystem() {
   Isolate* isolate = Isolate::Current();
   const GrowableObjectArray& libraries =
       GrowableObjectArray::Handle(isolate->object_store()->libraries());
 
-  const int num_libraries = libraries.Length();
+  const intptr_t num_libraries = libraries.Length();
   const Array& library_mirrors = Array::Handle(Array::New(num_libraries));
   Library& library = Library::Handle();
   Instance& library_mirror = Instance::Handle();
 
   for (int i = 0; i < num_libraries; i++) {
     library ^= libraries.At(i);
     library_mirror = CreateLibraryMirror(library);
     library_mirrors.SetAt(i, library_mirror);
   }
 
@@ skipping 1027 matching lines @@
   if (!closure.IsClosure()) {
     const Array& result_tuple = Array::Handle(Array::New(2));
     result_tuple.SetAt(0, Bool::False());
     return result_tuple.raw();
   }
 
   Function& function = Function::Handle();
   const bool callable = closure.IsCallable(&function, NULL);
   ASSERT(callable);
 
-  const int parts_len = lookup_parts.Length();
+  const intptr_t parts_len = lookup_parts.Length();
   // Lookup name is always the last part.
   const String& lookup_name = String::Handle(String::RawCast(
       lookup_parts.At(parts_len - 1)));
 
   String& part_name = String::Handle();
   Class& owner = Class::Handle(function.Owner());
   LibraryPrefix& prefix = LibraryPrefix::Handle();
   Library& this_library = Library::Handle(owner.library());
   Instance& result = Instance::Handle(Object::sentinel().raw());
   if (parts_len == 1) {
@@ skipping 85 matching lines @@
     function = klass.LookupStaticFunction(getter_name);
     if (!function.IsNull()) {
       // Invoke the getter.
       const Object& getter_result = Object::Handle(
           DartEntry::InvokeFunction(function, Object::empty_array()));
       if (getter_result.IsError()) {
         ThrowInvokeError(Error::Cast(getter_result));
         UNREACHABLE();
       }
       // Make room for the closure (receiver) in the argument list.
-      int numArgs = args.Length();
+      intptr_t numArgs = args.Length();
       const Array& call_args = Array::Handle(Array::New(numArgs + 1));
       Object& temp = Object::Handle();
       for (int i = 0; i < numArgs; i++) {
         temp = args.At(i);
         call_args.SetAt(i + 1, temp);
       }
       call_args.SetAt(0, getter_result);
       const Array& call_args_descriptor_array =
         Array::Handle(ArgumentsDescriptor::New(call_args.Length(), arg_names));
       // Call the closure.
@@ skipping 275 matching lines @@
     function = library.LookupLocalFunction(getter_name);
     if (!function.IsNull()) {
       // Invoke getter.
       const Object& getter_result = Object::Handle(
           DartEntry::InvokeFunction(function, Object::empty_array()));
       if (getter_result.IsError()) {
         ThrowInvokeError(Error::Cast(getter_result));
         UNREACHABLE();
       }
       // Make room for the closure (receiver) in arguments.
-      int numArgs = args.Length();
+      intptr_t numArgs = args.Length();
       const Array& call_args = Array::Handle(Array::New(numArgs + 1));
       Object& temp = Object::Handle();
       for (int i = 0; i < numArgs; i++) {
         temp = args.At(i);
         call_args.SetAt(i + 1, temp);
       }
       call_args.SetAt(0, getter_result);
       const Array& call_args_descriptor_array =
         Array::Handle(ArgumentsDescriptor::New(call_args.Length(), arg_names));
       // Call closure.
@@ skipping 220 matching lines @@
 }
 
 DEFINE_NATIVE_ENTRY(TypeMirror_moreSpecificTest, 2) {
   GET_NON_NULL_NATIVE_ARGUMENT(AbstractType, a, arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(AbstractType, b, arguments->NativeArgAt(1));
   return Bool::Get(a.IsMoreSpecificThan(b, NULL)).raw();
 }
 
 
 }  // namespace dart