Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: runtime/vm/dart.cc

Issue 169893003: Another round of cleanups for http://www.dartbug.com/15922 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/dart.h" 5 #include "vm/dart.h"
6 6
7 #include "vm/code_observers.h" 7 #include "vm/code_observers.h"
8 #include "vm/dart_api_state.h" 8 #include "vm/dart_api_state.h"
9 #include "vm/dart_entry.h" 9 #include "vm/dart_entry.h"
10 #include "vm/flags.h" 10 #include "vm/flags.h"
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 } 209 }
210 } else { 210 } else {
211 // Initialize from snapshot (this should replicate the functionality 211 // Initialize from snapshot (this should replicate the functionality
212 // of Object::Init(..) in a regular isolate creation path. 212 // of Object::Init(..) in a regular isolate creation path.
213 Object::InitFromSnapshot(isolate); 213 Object::InitFromSnapshot(isolate);
214 214
215 // TODO(turnidge): Remove once length is not part of the snapshot. 215 // TODO(turnidge): Remove once length is not part of the snapshot.
216 const Snapshot* snapshot = Snapshot::SetupFromBuffer(snapshot_buffer); 216 const Snapshot* snapshot = Snapshot::SetupFromBuffer(snapshot_buffer);
217 ASSERT(snapshot->kind() == Snapshot::kFull); 217 ASSERT(snapshot->kind() == Snapshot::kFull);
218 if (FLAG_trace_isolates) { 218 if (FLAG_trace_isolates) {
219 OS::Print("Size of isolate snapshot = %d\n", snapshot->length()); 219 OS::Print("Size of isolate snapshot = %" Pd64 "\n", snapshot->length());
220 } 220 }
221 SnapshotReader reader(snapshot->content(), snapshot->length(), 221 SnapshotReader reader(snapshot->content(), snapshot->length(),
222 Snapshot::kFull, isolate); 222 Snapshot::kFull, isolate);
223 reader.ReadFullSnapshot(); 223 reader.ReadFullSnapshot();
224 if (FLAG_trace_isolates) { 224 if (FLAG_trace_isolates) {
225 isolate->heap()->PrintSizes(); 225 isolate->heap()->PrintSizes();
226 isolate->megamorphic_cache_table()->PrintSizes(); 226 isolate->megamorphic_cache_table()->PrintSizes();
227 } 227 }
228 } 228 }
229 229
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
272 return predefined_handles_->handles_.AllocateScopedHandle(); 272 return predefined_handles_->handles_.AllocateScopedHandle();
273 } 273 }
274 274
275 275
276 bool Dart::IsReadOnlyHandle(uword address) { 276 bool Dart::IsReadOnlyHandle(uword address) {
277 ASSERT(predefined_handles_ != NULL); 277 ASSERT(predefined_handles_ != NULL);
278 return predefined_handles_->handles_.IsValidScopedHandle(address); 278 return predefined_handles_->handles_.IsValidScopedHandle(address);
279 } 279 }
280 280
281 } // namespace dart 281 } // namespace dart
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698