Another round of cleanups for http://www.dartbug.com/15922

runtime/bin/signal_blocker.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef BIN_SIGNAL_BLOCKER_H_
 #define BIN_SIGNAL_BLOCKER_H_
 
 #include "platform/globals.h"
 
 #if defined(TARGET_OS_WINDOWS)
@@ skipping 38 matching lines @@
     ASSERT(r == 0);
   }
 
  private:
   sigset_t old;
 };
 
 
 #define TEMP_FAILURE_RETRY_BLOCK_SIGNALS(expression)                           \
     ({ ThreadSignalBlocker tsb(SIGPROF);                                       \
-       int64_t __result;                                                       \
+       intptr_t __result;                                                      \
        do {                                                                    \
-         __result = static_cast<int64_t>(expression);                          \
-       } while (__result == -1L && errno == EINTR);                            \
+         __result = (expression);                                              \
+       } while ((__result == -1L) && (errno == EINTR));                        \
        __result; })
 
 #define VOID_TEMP_FAILURE_RETRY_BLOCK_SIGNALS(expression)                      \
     (static_cast<void>(TEMP_FAILURE_RETRY_BLOCK_SIGNALS(expression)))

[siva, 2014/02/19 00:34:04]

Maybe in another CL we should consider co locating this with TEMP_FAILURE_RETRY
if both versions block and normal are required.

[Ivan Posva, 2014/02/19 04:04:23]

I don't think we need both versions. Different CL.

 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // BIN_SIGNAL_BLOCKER_H_