Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1672853002: Move sticky_error_ from isolate to thread (Closed)

Created:
4 years, 10 months ago by srdjan
Modified:
4 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : r #

Patch Set 3 : r #

Total comments: 4

Patch Set 4 : Comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -107 lines) Patch
M runtime/vm/class_finalizer.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/compiler.cc View 1 10 chunks +19 lines, -28 lines 0 comments Download
M runtime/vm/dart.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 4 chunks +9 lines, -9 lines 0 comments Download
M runtime/vm/debugger.cc View 1 7 chunks +10 lines, -13 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/isolate.cc View 1 9 chunks +15 lines, -15 lines 0 comments Download
M runtime/vm/longjump.cc View 2 chunks +1 line, -2 lines 0 comments Download
M runtime/vm/message_handler.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/object_store.h View 3 chunks +1 line, -11 lines 0 comments Download
M runtime/vm/object_store.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/parser.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M runtime/vm/precompiler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/regexp_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/service_isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/snapshot.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/thread.h View 1 3 chunks +8 lines, -0 lines 0 comments Download
M runtime/vm/thread.cc View 1 2 3 3 chunks +26 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
srdjan
4 years, 10 months ago (2016-02-05 21:26:48 UTC) #2
siva
lgtm https://codereview.chromium.org/1672853002/diff/30001/runtime/vm/thread.cc File runtime/vm/thread.cc (right): https://codereview.chromium.org/1672853002/diff/30001/runtime/vm/thread.cc#newcode191 runtime/vm/thread.cc:191: // ASSERT(Thread::Current()->IsMutatorThread()); This TODO and ASSERT can be ...
4 years, 10 months ago (2016-02-05 22:46:37 UTC) #3
srdjan
https://codereview.chromium.org/1672853002/diff/30001/runtime/vm/thread.cc File runtime/vm/thread.cc (right): https://codereview.chromium.org/1672853002/diff/30001/runtime/vm/thread.cc#newcode191 runtime/vm/thread.cc:191: // ASSERT(Thread::Current()->IsMutatorThread()); On 2016/02/05 22:46:36, siva wrote: > This ...
4 years, 10 months ago (2016-02-05 23:34:33 UTC) #4
srdjan
4 years, 10 months ago (2016-02-05 23:46:59 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:50001) manually as
4316d1bd175ef884e1b623830ce8d8f239894d86 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698