runtime/vm/message_handler.cc - Issue 1672853002: Move sticky_error_ from isolate to thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/message_handler.cc

Issue 1672853002: Move sticky_error_ from isolate to thread (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Comments addressed Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/message_handler.cc

diff --git a/runtime/vm/message_handler.cc b/runtime/vm/message_handler.cc

index 2340b65d766794da64779349e0449d8ab03a63a5..e64a05a105aa794d82d836299abacd1f51f93fcf 100644

--- a/runtime/vm/message_handler.cc

+++ b/runtime/vm/message_handler.cc

@@ -382,8 +382,7 @@ void MessageHandler::TaskCallback() {

}

if (FLAG_trace_isolates) {

if (status != kOK && isolate() != NULL) {

- const Error& error =

- Error::Handle(isolate()->object_store()->sticky_error());

+ const Error& error = Error::Handle(thread()->sticky_error());

OS::Print("[-] Stopping message handler (%s):\n"

"\thandler: %s\n"

"\terror: %s\n",

« no previous file with comments | « runtime/vm/longjump.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »