runtime/vm/service_isolate.cc - Issue 1672853002: Move sticky_error_ from isolate to thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/service_isolate.cc

Issue 1672853002: Move sticky_error_ from isolate to thread (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Comments addressed Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/service_isolate.cc

diff --git a/runtime/vm/service_isolate.cc b/runtime/vm/service_isolate.cc

index dcfc541befcbf68dad0ed0eb4349ee296faec1c1..a005ada3263333868242e81a564169988626a658 100644

--- a/runtime/vm/service_isolate.cc

+++ b/runtime/vm/service_isolate.cc

@@ -367,7 +367,7 @@ class RunServiceTask : public ThreadPool::Task {

StackZone zone(T);

HandleScope handle_scope(T);

Error& error = Error::Handle(Z);

- error = I->object_store()->sticky_error();

+ error = T->sticky_error();

if (!error.IsNull() && !error.IsUnwindError()) {

OS::PrintErr("vm-service: Error: %s\n", error.ToErrorCString());

}

« no previous file with comments | « runtime/vm/regexp_parser.cc ('k') | runtime/vm/snapshot.cc » ('j') | no next file with comments »