Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 1672853002: Move sticky_error_ from isolate to thread (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Comments addressed Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc
index b0022327c28a1daa6b22519860a2e3822c770fdd..5dc4d168f0e2581db3ada3b01256a7e43186108e 100644
--- a/runtime/vm/dart_api_impl.cc
+++ b/runtime/vm/dart_api_impl.cc
@@ -459,8 +459,8 @@ Dart_Handle Api::CheckAndFinalizePendingClasses(Thread* thread) {
if (ClassFinalizer::ProcessPendingClasses()) {
return Api::Success();
}
- ASSERT(isolate->object_store()->sticky_error() != Object::null());
- return Api::NewHandle(thread, isolate->object_store()->sticky_error());
+ ASSERT(thread->sticky_error() != Object::null());
+ return Api::NewHandle(thread, thread->sticky_error());
}
@@ -1622,9 +1622,9 @@ DART_EXPORT Dart_Handle Dart_RunLoop() {
}
::Dart_EnterIsolate(Api::CastIsolate(I));
}
- if (I->object_store()->sticky_error() != Object::null()) {
- Dart_Handle error = Api::NewHandle(T, I->object_store()->sticky_error());
- I->object_store()->clear_sticky_error();
+ if (T->sticky_error() != Object::null()) {
+ Dart_Handle error = Api::NewHandle(T, T->sticky_error());
+ T->clear_sticky_error();
return error;
}
if (FLAG_print_class_table) {
@@ -1643,8 +1643,8 @@ DART_EXPORT Dart_Handle Dart_HandleMessage() {
API_TIMELINE_BEGIN_END;
TransitionNativeToVM transition(T);
if (I->message_handler()->HandleNextMessage() != MessageHandler::kOK) {
- Dart_Handle error = Api::NewHandle(T, I->object_store()->sticky_error());
- I->object_store()->clear_sticky_error();
+ Dart_Handle error = Api::NewHandle(T, T->sticky_error());
+ T->clear_sticky_error();
return error;
}
return Api::Success();
@@ -1659,8 +1659,8 @@ DART_EXPORT Dart_Handle Dart_HandleMessages() {
API_TIMELINE_BEGIN_END;
TransitionNativeToVM transition(T);
if (I->message_handler()->HandleAllMessages() != MessageHandler::kOK) {
- Dart_Handle error = Api::NewHandle(T, I->object_store()->sticky_error());
- I->object_store()->clear_sticky_error();
+ Dart_Handle error = Api::NewHandle(T, T->sticky_error());
+ T->clear_sticky_error();
return error;
}
return Api::Success();
« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698