Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: runtime/vm/object.cc

Issue 1672853002: Move sticky_error_ from isolate to thread (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Comments addressed Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/message_handler.cc ('k') | runtime/vm/object_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index 873ff206b8bc0cfedd860e4841737d6418a91917..9dc1148c4fcac15882d58fe0c8f2f18b5882d1db 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -843,6 +843,13 @@ void Object::InitOnce(Isolate* isolate) {
Report::kBailout,
Heap::kOld);
+ // Some thread fields need to be reinitialized as null constants have not been
+ // initialized until now.
+ Thread* thr = Thread::Current();
+ ASSERT(thr != NULL);
+ thr->clear_sticky_error();
+ thr->clear_pending_functions();
+
ASSERT(!null_object_->IsSmi());
ASSERT(!null_array_->IsSmi());
ASSERT(null_array_->IsArray());
« no previous file with comments | « runtime/vm/message_handler.cc ('k') | runtime/vm/object_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698