Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: runtime/vm/object_store.h

Issue 1672853002: Move sticky_error_ from isolate to thread (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Comments addressed Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/object_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object_store.h
diff --git a/runtime/vm/object_store.h b/runtime/vm/object_store.h
index 2b689025cb964ecd56706ae7f31a94357adffefd..2cab02ba46bdd3093ab4afb09cc572a87c91c54b 100644
--- a/runtime/vm/object_store.h
+++ b/runtime/vm/object_store.h
@@ -365,15 +365,6 @@ class ObjectStore {
return error_listeners_;
}
- RawError* sticky_error() const { return sticky_error_; }
- void set_sticky_error(const Error& value) {
- // TODO(asiva): Move sticky_error_ into thread specific area.
- ASSERT(Thread::Current()->IsMutatorThread());
- ASSERT(!value.IsNull());
- sticky_error_ = value.raw();
- }
- void clear_sticky_error() { sticky_error_ = Error::null(); }
-
RawContext* empty_context() const { return empty_context_; }
void set_empty_context(const Context& value) {
empty_context_ = value.raw();
@@ -488,7 +479,7 @@ class ObjectStore {
// Called to initialize objects required by the vm but which invoke
// dart code. If an error occurs then false is returned and error
- // information is stored in sticky_error().
+ // information is stored in Thread::sticky_error().
bool PreallocateObjects();
void InitKnownObjects();
@@ -563,7 +554,6 @@ class ObjectStore {
RawGrowableObjectArray* resume_capabilities_;
RawGrowableObjectArray* exit_listeners_;
RawGrowableObjectArray* error_listeners_;
- RawError* sticky_error_;
RawContext* empty_context_;
RawInstance* stack_overflow_;
RawInstance* out_of_memory_;
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/object_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698