Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1660593004: Landing Recent QUIC changes until 01/28/2016 18:41 UTC (Closed)

Created:
4 years, 10 months ago by ramant (doing other things)
Modified:
4 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Final_0202
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Landing Recent QUIC changes until 01/28/2016 18:41 UTC use std::unordered_map and std::unordered_set in QUIC code instead of hash_map and hash_set. Merge internal change: 113278032 https://codereview.chromium.org/1663703003/ Postpone checking peer address change after the packet is successfully decrypted. Protected behind FLAGS_check_peer_address_change_after_decryption. Merge internal change: 113259990 https://codereview.chromium.org/1663493003/ Fixing up includes for common_cert_set.cc common_cert_set_1.cc and 2.cc need to handle size_t correctly Merge internal change: 113259867 https://codereview.chromium.org/1661883002/ Make QUIC's SerializedPacket contain QuicFrames, rather than a pointer to QuicFrames. No functional change. Estimated to save ~0.8% CPU. Merge internal change: 113222997 https://codereview.chromium.org/1666553002/ factor out path id + packet number packing code from the QUIC aead code into QuicUtils::PackPathIdAndPacketNumber to reduce code duplication (which is doubled in Chromium because of NSS & OpenSSL versions of this code). Merge internal change: 113205205 https://codereview.chromium.org/1660253003/ Add FLAGS_quic_crypto_server_config_default_has_chacha20, to allow internal server to pretend it doesn't support ChaCha20. Merge internal change: 113179972 https://codereview.chromium.org/1665693002/ Remove a test-only SerializedPacket constructor from QUIC. n/a (Test-only change) Merge internal change: 113125505 https://codereview.chromium.org/1661863002/ Fix a bug in QUIC's Slow Start Large Reduction connection option that increased packet loss. Small functional change. Merge internal change: 113110142 https://codereview.chromium.org/1660143003/ Make a SerializedPacket a member variable of QuicPacketCreator to replace the corresponding fields. No functional change, not flag protected. Merge internal change: 113108401 https://codereview.chromium.org/1658393003/ Deprecate FLAGS_quic_general_loss_algorithm. Merge internal change: 113076102 https://codereview.chromium.org/1667513002/ Move QuicPacketCreator::SerializeAllFrames into QuicPacketCreatorPeer. No functional change. Merge internal change: 113072084 https://codereview.chromium.org/1658373002/ R=rch@chromium.org Committed: https://crrev.com/f85706db6ab7f2e5a5feeb89a8cd895fcb176f0b Cr-Commit-Position: refs/heads/master@{#373440}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+604 lines, -1402 lines) Patch
M net/net.gypi View 2 chunks +0 lines, -6 lines 0 comments Download
M net/quic/congestion_control/general_loss_algorithm_test.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/quic/congestion_control/loss_detection_interface.cc View 2 chunks +1 line, -13 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_bytes_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
D net/quic/congestion_control/tcp_loss_algorithm.h View 1 chunk +0 lines, -54 lines 0 comments Download
D net/quic/congestion_control/tcp_loss_algorithm.cc View 1 chunk +0 lines, -105 lines 0 comments Download
D net/quic/congestion_control/tcp_loss_algorithm_test.cc View 1 chunk +0 lines, -216 lines 0 comments Download
D net/quic/congestion_control/time_loss_algorithm.h View 1 chunk +0 lines, -58 lines 0 comments Download
D net/quic/congestion_control/time_loss_algorithm.cc View 1 chunk +0 lines, -82 lines 0 comments Download
D net/quic/congestion_control/time_loss_algorithm_test.cc View 1 chunk +0 lines, -148 lines 0 comments Download
M net/quic/crypto/aead_base_decrypter_nss.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M net/quic/crypto/aead_base_decrypter_openssl.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M net/quic/crypto/aead_base_encrypter_nss.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M net/quic/crypto/aead_base_encrypter_openssl.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M net/quic/crypto/common_cert_set.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/common_cert_set.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config_test.cc View 1 chunk +30 lines, -1 line 0 comments Download
M net/quic/quic_chromium_client_session.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_connection.h View 3 chunks +17 lines, -8 lines 0 comments Download
M net/quic/quic_connection.cc View 13 chunks +126 lines, -38 lines 0 comments Download
M net/quic/quic_connection_test.cc View 28 chunks +83 lines, -261 lines 0 comments Download
M net/quic/quic_flags.h View 2 chunks +4 lines, -1 line 0 comments Download
M net/quic/quic_flags.cc View 2 chunks +10 lines, -4 lines 0 comments Download
M net/quic/quic_frame_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_framer.h View 2 chunks +4 lines, -2 lines 0 comments Download
M net/quic/quic_multipath_received_packet_manager.h View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/quic_multipath_transmissions_map.h View 2 chunks +13 lines, -3 lines 0 comments Download
M net/quic/quic_multipath_transmissions_map.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_multipath_transmissions_map_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_packet_creator.h View 9 chunks +30 lines, -53 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 26 chunks +128 lines, -138 lines 0 comments Download
M net/quic/quic_packet_creator_test.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M net/quic/quic_packet_generator_test.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +1 line, -15 lines 0 comments Download
M net/quic/quic_protocol.cc View 2 chunks +0 lines, -32 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 4 chunks +14 lines, -46 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M net/quic/quic_session.h View 3 chunks +5 lines, -3 lines 0 comments Download
M net/quic/quic_unacked_packet_map.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M net/quic/quic_unacked_packet_map_test.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M net/quic/quic_utils.h View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/quic_utils.cc View 1 chunk +17 lines, -4 lines 0 comments Download
M net/quic/spdy_utils_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_packet_creator_peer.h View 1 chunk +7 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_packet_creator_peer.cc View 4 chunks +29 lines, -9 lines 0 comments Download
M net/quic/test_tools/quic_session_peer.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_session_peer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/tools/quic/quic_in_memory_cache.h View 4 chunks +9 lines, -8 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
ramant (doing other things)
4 years, 10 months ago (2016-02-03 19:51:12 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1660593004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1660593004/1
4 years, 10 months ago (2016-02-03 21:23:08 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-03 22:38:16 UTC) #5
Ryan Hamilton
lgtm
4 years, 10 months ago (2016-02-04 00:15:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1660593004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1660593004/1
4 years, 10 months ago (2016-02-04 02:35:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 02:43:10 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 02:44:36 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f85706db6ab7f2e5a5feeb89a8cd895fcb176f0b
Cr-Commit-Position: refs/heads/master@{#373440}

Powered by Google App Engine
This is Rietveld 408576698