Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: net/quic/congestion_control/time_loss_algorithm_test.cc

Issue 1660593004: Landing Recent QUIC changes until 01/28/2016 18:41 UTC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Final_0202
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/congestion_control/time_loss_algorithm.cc ('k') | net/quic/crypto/aead_base_decrypter_nss.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/congestion_control/time_loss_algorithm_test.cc
diff --git a/net/quic/congestion_control/time_loss_algorithm_test.cc b/net/quic/congestion_control/time_loss_algorithm_test.cc
deleted file mode 100644
index d52e550c2d7b9479cd0fd172fc41be29f7ca6aef..0000000000000000000000000000000000000000
--- a/net/quic/congestion_control/time_loss_algorithm_test.cc
+++ /dev/null
@@ -1,148 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "net/quic/congestion_control/time_loss_algorithm.h"
-
-#include <algorithm>
-
-#include "base/logging.h"
-#include "base/stl_util.h"
-#include "net/quic/congestion_control/rtt_stats.h"
-#include "net/quic/quic_unacked_packet_map.h"
-#include "net/quic/test_tools/mock_clock.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-using std::vector;
-
-namespace net {
-namespace test {
-namespace {
-
-// Default packet length.
-const uint32_t kDefaultLength = 1000;
-
-class TimeLossAlgorithmTest : public ::testing::Test {
- protected:
- TimeLossAlgorithmTest() {
- rtt_stats_.UpdateRtt(QuicTime::Delta::FromMilliseconds(100),
- QuicTime::Delta::Zero(), clock_.Now());
- }
-
- ~TimeLossAlgorithmTest() override { STLDeleteElements(&packets_); }
-
- void SendDataPacket(QuicPacketNumber packet_number) {
- packets_.push_back(new QuicEncryptedPacket(nullptr, kDefaultLength));
- SerializedPacket packet(kDefaultPathId, packet_number,
- PACKET_1BYTE_PACKET_NUMBER, packets_.back(), 0,
- new QuicFrames(), false, false);
- unacked_packets_.AddSentPacket(&packet, 0, NOT_RETRANSMISSION, clock_.Now(),
- 1000, true);
- }
-
- void VerifyLosses(QuicPacketNumber largest_observed,
- QuicPacketNumber* losses_expected,
- size_t num_losses) {
- PacketNumberSet lost_packets = loss_algorithm_.DetectLostPackets(
- unacked_packets_, clock_.Now(), largest_observed, rtt_stats_);
- EXPECT_EQ(num_losses, lost_packets.size());
- for (size_t i = 0; i < num_losses; ++i) {
- EXPECT_TRUE(ContainsKey(lost_packets, losses_expected[i]));
- }
- }
-
- vector<QuicEncryptedPacket*> packets_;
- QuicUnackedPacketMap unacked_packets_;
- TimeLossAlgorithm loss_algorithm_;
- RttStats rtt_stats_;
- MockClock clock_;
-};
-
-TEST_F(TimeLossAlgorithmTest, NoLossFor500Nacks) {
- const size_t kNumSentPackets = 5;
- // Transmit 5 packets.
- for (size_t i = 1; i <= kNumSentPackets; ++i) {
- SendDataPacket(i);
- }
- unacked_packets_.RemoveFromInFlight(2);
- for (uint16_t i = 1; i < 500; ++i) {
- unacked_packets_.NackPacket(1, i);
- VerifyLosses(2, nullptr, 0);
- }
- EXPECT_EQ(rtt_stats_.smoothed_rtt().Multiply(1.25),
- loss_algorithm_.GetLossTimeout().Subtract(clock_.Now()));
-}
-
-TEST_F(TimeLossAlgorithmTest, NoLossUntilTimeout) {
- const size_t kNumSentPackets = 10;
- // Transmit 10 packets at 1/10th an RTT interval.
- for (size_t i = 1; i <= kNumSentPackets; ++i) {
- SendDataPacket(i);
- clock_.AdvanceTime(rtt_stats_.smoothed_rtt().Multiply(0.1));
- }
- // Expect the timer to not be set.
- EXPECT_EQ(QuicTime::Zero(), loss_algorithm_.GetLossTimeout());
- // The packet should not be lost until 1.25 RTTs pass.
- unacked_packets_.NackPacket(1, 1);
- unacked_packets_.RemoveFromInFlight(2);
- VerifyLosses(2, nullptr, 0);
- // Expect the timer to be set to 0.25 RTT's in the future.
- EXPECT_EQ(rtt_stats_.smoothed_rtt().Multiply(0.25),
- loss_algorithm_.GetLossTimeout().Subtract(clock_.Now()));
- unacked_packets_.NackPacket(1, 5);
- VerifyLosses(2, nullptr, 0);
- clock_.AdvanceTime(rtt_stats_.smoothed_rtt().Multiply(0.25));
- QuicPacketNumber lost[] = {1};
- VerifyLosses(2, lost, arraysize(lost));
- EXPECT_EQ(QuicTime::Zero(), loss_algorithm_.GetLossTimeout());
-}
-
-TEST_F(TimeLossAlgorithmTest, NoLossWithoutNack) {
- const size_t kNumSentPackets = 10;
- // Transmit 10 packets at 1/10th an RTT interval.
- for (size_t i = 1; i <= kNumSentPackets; ++i) {
- SendDataPacket(i);
- clock_.AdvanceTime(rtt_stats_.smoothed_rtt().Multiply(0.1));
- }
- // Expect the timer to not be set.
- EXPECT_EQ(QuicTime::Zero(), loss_algorithm_.GetLossTimeout());
- // The packet should not be lost without a nack.
- unacked_packets_.RemoveFromInFlight(1);
- VerifyLosses(1, nullptr, 0);
- // The timer should still not be set.
- EXPECT_EQ(QuicTime::Zero(), loss_algorithm_.GetLossTimeout());
- clock_.AdvanceTime(rtt_stats_.smoothed_rtt().Multiply(0.25));
- VerifyLosses(1, nullptr, 0);
- clock_.AdvanceTime(rtt_stats_.smoothed_rtt());
- VerifyLosses(1, nullptr, 0);
-
- EXPECT_EQ(QuicTime::Zero(), loss_algorithm_.GetLossTimeout());
-}
-
-TEST_F(TimeLossAlgorithmTest, MultipleLossesAtOnce) {
- const size_t kNumSentPackets = 10;
- // Transmit 10 packets at once and then go forward an RTT.
- for (size_t i = 1; i <= kNumSentPackets; ++i) {
- SendDataPacket(i);
- }
- clock_.AdvanceTime(rtt_stats_.smoothed_rtt());
- // Expect the timer to not be set.
- EXPECT_EQ(QuicTime::Zero(), loss_algorithm_.GetLossTimeout());
- // The packet should not be lost until 1.25 RTTs pass.
- for (size_t i = 1; i < kNumSentPackets; ++i) {
- unacked_packets_.NackPacket(i, 1);
- }
- unacked_packets_.RemoveFromInFlight(10);
- VerifyLosses(10, nullptr, 0);
- // Expect the timer to be set to 0.25 RTT's in the future.
- EXPECT_EQ(rtt_stats_.smoothed_rtt().Multiply(0.25),
- loss_algorithm_.GetLossTimeout().Subtract(clock_.Now()));
- clock_.AdvanceTime(rtt_stats_.smoothed_rtt().Multiply(0.25));
- QuicPacketNumber lost[] = {1, 2, 3, 4, 5, 6, 7, 8, 9};
- VerifyLosses(10, lost, arraysize(lost));
- EXPECT_EQ(QuicTime::Zero(), loss_algorithm_.GetLossTimeout());
-}
-
-} // namespace
-} // namespace test
-} // namespace net
« no previous file with comments | « net/quic/congestion_control/time_loss_algorithm.cc ('k') | net/quic/crypto/aead_base_decrypter_nss.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698