Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Issue 1662083003: Change server push unit tests of quic toy server session to make tests (Closed)

Created:
4 years, 10 months ago by ramant (doing other things)
Modified:
4 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, danzh1
Base URL:
https://chromium.googlesource.com/chromium/src.git@Final_0203
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change server push unit tests of quic toy server session to make tests pass when FLAGS_quic_cede_correctly is true. Since cl/112799471 changes quic priority behavior of connection level flow control blocked streams, and currently the server push unit tests uses connection level flow control to keep push streams open, the tests failed when new behavior is introduced. This CL changes the tests to use stream level flow control instead of connection level. Merge internal change: 113275797 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -68 lines) Patch
M net/tools/quic/quic_simple_server_session_test.cc View 8 chunks +130 lines, -68 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
4 years, 10 months ago (2016-02-03 21:49:06 UTC) #1
Ryan Hamilton
4 years, 10 months ago (2016-02-04 00:14:35 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698