Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: net/quic/quic_sent_packet_manager_test.cc

Issue 1660593004: Landing Recent QUIC changes until 01/28/2016 18:41 UTC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Final_0202
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_sent_packet_manager.cc ('k') | net/quic/quic_session.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_sent_packet_manager_test.cc
diff --git a/net/quic/quic_sent_packet_manager_test.cc b/net/quic/quic_sent_packet_manager_test.cc
index 66222aa9ecc99dcfab4ec2c850a3206e0233513c..0fe84fb1fece3412c563f817f2df0a6e087f0a05 100644
--- a/net/quic/quic_sent_packet_manager_test.cc
+++ b/net/quic/quic_sent_packet_manager_test.cc
@@ -195,22 +195,21 @@ class QuicSentPacketManagerTest : public ::testing::TestWithParam<bool> {
SerializedPacket CreatePacket(QuicPacketNumber packet_number,
bool retransmittable) {
packets_.push_back(new QuicEncryptedPacket(nullptr, kDefaultLength));
- QuicFrames* frames = nullptr;
+ SerializedPacket packet(kDefaultPathId, packet_number,
+ PACKET_6BYTE_PACKET_NUMBER, packets_.back(), 0u,
+ false, false);
if (retransmittable) {
- frames = new QuicFrames();
- frames->push_back(
+ packet.retransmittable_frames.push_back(
QuicFrame(new QuicStreamFrame(kStreamId, false, 0, StringPiece())));
}
- return SerializedPacket(kDefaultPathId, packet_number,
- PACKET_6BYTE_PACKET_NUMBER, packets_.back(), 0u,
- frames, false, false);
+ return packet;
}
SerializedPacket CreateFecPacket(QuicPacketNumber packet_number) {
packets_.push_back(new QuicEncryptedPacket(nullptr, kDefaultLength));
SerializedPacket serialized(kDefaultPathId, packet_number,
PACKET_6BYTE_PACKET_NUMBER, packets_.back(), 0u,
- nullptr, false, false);
+ false, false);
serialized.is_fec_packet = true;
return serialized;
}
@@ -232,7 +231,7 @@ class QuicSentPacketManagerTest : public ::testing::TestWithParam<bool> {
.Times(1)
.WillOnce(Return(true));
SerializedPacket packet(CreateDataPacket(packet_number));
- packet.retransmittable_frames->push_back(
+ packet.retransmittable_frames.push_back(
QuicFrame(new QuicStreamFrame(1, false, 0, StringPiece())));
packet.has_crypto_handshake = IS_HANDSHAKE;
manager_.OnPacketSent(&packet, 0, clock_.Now(), packet.packet->length(),
« no previous file with comments | « net/quic/quic_sent_packet_manager.cc ('k') | net/quic/quic_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698