Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 1655363002: Add vector VEOR instruction to the integrated ARM assembler. (Closed)

Created:
4 years, 10 months ago by Karl
Modified:
4 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add DART file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -11 lines) Patch
M src/DartARM32/assembler_arm.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/DartARM32/assembler_arm.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceAssemblerARM32.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/IceInstARM32.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceTargetLoweringARM32.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tests_lit/assembler/arm32/xor-vec.ll View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Karl
4 years, 10 months ago (2016-02-02 22:16:19 UTC) #3
Eric Holk
lgtm
4 years, 10 months ago (2016-02-02 22:24:48 UTC) #4
Jim Stichnoth
lgtm
4 years, 10 months ago (2016-02-02 23:54:00 UTC) #5
Karl
4 years, 10 months ago (2016-02-03 21:21:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
625dfb384b3993329861d27e22689d4cc1ae1e4b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698