src/IceInstARM32.cpp - Issue 1655363002: Add vector VEOR instruction to the integrated ARM assembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstARM32.cpp

Issue 1655363002: Add vector VEOR instruction to the integrated ARM assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Add DART file. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInstARM32.cpp

diff --git a/src/IceInstARM32.cpp b/src/IceInstARM32.cpp

index 312a3d11844b9613c6fb09959ffea335bc1f4d9c..fbf9facc165f82d2564c6ff5f0a88d79be722bb4 100644

--- a/src/IceInstARM32.cpp

+++ b/src/IceInstARM32.cpp

@@ -680,8 +680,8 @@ template <> void InstARM32Veor::emitIAS(const Cfg *Func) const {

auto *Asm = Func->getAssembler<ARM32::AssemblerARM32>();

const Variable *Dest = getDest();

if (isVectorType(Dest->getType())) {

- // TODO(kschimpf): Add support for this case

- emitUsingTextFixup(Func);

+ Asm->veorq(Dest, getSrc(0), getSrc(1));

+ assert(!Asm->needsTextFixup());

return;

}

assert(Dest->getType() == IceType_f64);

« no previous file with comments | « src/IceAssemblerARM32.cpp ('k') | src/IceTargetLoweringARM32.cpp » ('j') | no next file with comments »