Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 1651263003: Detemplatize TextIterator::copyTextTo with ForwardsTextBuffer (Closed)

Created:
4 years, 10 months ago by Xiaocheng
Modified:
4 years, 10 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@text_buffers
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Detemplatize TextIterator::copyTextTo with ForwardsTextBuffer This is part of a bigger CL [1], which is in turn part of another even bigger CL [2]. [1] https://codereview.chromium.org/1647483003 [2] https://codereview.chromium.org/1604783002 BUG=n/a TEST=n/a; no behavior change Committed: https://crrev.com/75b7224278e2e08df6ae31e3257e8cd91b40ef90 Cr-Commit-Position: refs/heads/master@{#373199}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Change ref parameters to ptrs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -83 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 2 6 chunks +17 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/CharacterIterator.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIterator.h View 1 2 2 chunks +4 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIteratorTest.cpp View 1 2 2 chunks +34 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.h View 1 2 2 chunks +2 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.cpp View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/WordAwareIterator.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/WordAwareIterator.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/mac/WebSubstringUtil.mm View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (5 generated)
Xiaocheng
PTAL.
4 years, 10 months ago (2016-02-02 10:01:40 UTC) #2
Xiaocheng
Ping...
4 years, 10 months ago (2016-02-03 06:11:53 UTC) #3
yosin_UTC9
I know it is too early to say so, but we would like to avoid ...
4 years, 10 months ago (2016-02-03 06:39:30 UTC) #4
Xiaocheng
On 2016/02/03 at 06:39:30, yosin wrote: > I know it is too early to say ...
4 years, 10 months ago (2016-02-03 07:41:30 UTC) #5
yosin_UTC9
lgtm Thanks for simplification!
4 years, 10 months ago (2016-02-03 07:52:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1651263003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1651263003/40001
4 years, 10 months ago (2016-02-03 07:53:31 UTC) #8
tkent
web/ lgtm
4 years, 10 months ago (2016-02-03 08:02:32 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/142014)
4 years, 10 months ago (2016-02-03 08:03:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1651263003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1651263003/40001
4 years, 10 months ago (2016-02-03 08:06:19 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-03 08:34:07 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 08:35:03 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/75b7224278e2e08df6ae31e3257e8cd91b40ef90
Cr-Commit-Position: refs/heads/master@{#373199}

Powered by Google App Engine
This is Rietveld 408576698