third_party/WebKit/Source/core/editing/iterators/WordAwareIterator.cpp - Issue 1651263003: Detemplatize TextIterator::copyTextTo with ForwardsTextBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/iterators/WordAwareIterator.cpp

Issue 1651263003: Detemplatize TextIterator::copyTextTo with ForwardsTextBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@text_buffers

Patch Set: Change ref parameters to ptrs Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/iterators/WordAwareIterator.h ('k') | third_party/WebKit/Source/web/mac/WebSubstringUtil.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/iterators/WordAwareIterator.cpp

diff --git a/third_party/WebKit/Source/core/editing/iterators/WordAwareIterator.cpp b/third_party/WebKit/Source/core/editing/iterators/WordAwareIterator.cpp

index 804840a29aab6c5643ffb0045b85b9df5c49c16a..c2c9ed9535122fc0aafe3623ec7f887b0312e3e0 100644

--- a/third_party/WebKit/Source/core/editing/iterators/WordAwareIterator.cpp

+++ b/third_party/WebKit/Source/core/editing/iterators/WordAwareIterator.cpp

@@ -66,7 +66,7 @@ void WordAwareIterator::advance()

// If this is the first chunk that failed, save it in m_buffer before look ahead.

if (m_buffer.isEmpty())

- m_textIterator.copyTextTo(m_buffer);

+ m_textIterator.copyTextTo(&m_buffer);

// Look ahead to next chunk. If it is whitespace or a break, we can use the previous stuff

m_textIterator.advance();

@@ -76,7 +76,7 @@ void WordAwareIterator::advance()

}

// Start gobbling chunks until we get to a suitable stopping point

- m_textIterator.copyTextTo(m_buffer);

+ m_textIterator.copyTextTo(&m_buffer);

}