third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp - Issue 1651263003: Detemplatize TextIterator::copyTextTo with ForwardsTextBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp

Issue 1651263003: Detemplatize TextIterator::copyTextTo with ForwardsTextBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@text_buffers

Patch Set: Change ref parameters to ptrs Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/iterators/CharacterIterator.h ('k') | third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp

diff --git a/third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp b/third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp

index ced829213a513fa737f4e60d321cbbe34f8c93f2..e3e1e341615c574856492bb28ab7b7a0b07eb908 100644

--- a/third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp

+++ b/third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp

@@ -174,6 +174,12 @@ void CharacterIteratorAlgorithm<Strategy>::advance(int count)

}

template <typename Strategy>

+void CharacterIteratorAlgorithm<Strategy>::copyTextTo(ForwardsTextBuffer* output)

+ m_textIterator.copyTextTo(output, m_runOffset);

+template <typename Strategy>

EphemeralRangeTemplate<Strategy> CharacterIteratorAlgorithm<Strategy>::calculateCharacterSubrange(int offset, int length)

{

advance(offset);