Detemplatize SimplifiedBackwardsTextIterator::copyTextTo with BackwardsTextBuffer

Detemplatize SimplifiedBackwardsTextIterator::copyTextTo with BackwardsTextBuffer

This is the last part of a bigger CL [1], which is in turn part of another even
bigger CL [2].

[1] https://codereview.chromium.org/1647483003
[2] https://codereview.chromium.org/1604783002

BUG=n/a
TEST=n/a; no behavior change

Committed: https://crrev.com/888f85bf9bfc7b8c3d3746d247c87a121a3908f2
Cr-Commit-Position: refs/heads/master@{#373202}

[Xiaocheng, 2016-02-03 08:35:23]

Description was changed from

==========
Detemplatize SimplifiedBackwardsTextIterator::copyTextTo with
BackwardsTextBuffer

This is part of a bigger CL [1], which is in turn part of another even
bigger CL [2].

[1] https://codereview.chromium.org/1647483003
[2] https://codereview.chromium.org/1604783002

BUG=n/a
TEST=n/a; no behavior change
==========

to

==========
Detemplatize SimplifiedBackwardsTextIterator::copyTextTo with
BackwardsTextBuffer

This is the last part of a bigger CL [1], which is in turn part of another even
bigger CL [2].

[1] https://codereview.chromium.org/1647483003
[2] https://codereview.chromium.org/1604783002

BUG=n/a
TEST=n/a; no behavior change
==========

[Xiaocheng, 2016-02-03 08:35:23]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-02-03 08:35:32]

PTAL.

[yosin_UTC9, 2016-02-03 08:44:25]

lgtm w/ small nit

Thanks for simplification!

https://codereview.chromium.org/1657203003/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp
(right):

https://codereview.chromium.org/1657203003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp:437:
ASSERT(output);
nit: We don't need to have |ASSERT(output)|, since we use them below.

[Xiaocheng, 2016-02-03 08:52:46]

Thanks for the prompt response!

https://codereview.chromium.org/1657203003/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp
(right):

https://codereview.chromium.org/1657203003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp:437:
ASSERT(output);
On 2016/02/03 at 08:44:25, Yosi_UTC9 wrote:
> nit: We don't need to have |ASSERT(output)|, since we use them below.

There's a symmetric assertion in crrev.com/1651263003 (just landed) for
ForwardsTextBuffer...

So let's just keep them symmetric.

[Xiaocheng, 2016-02-03 09:15:15]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-02-03 09:16:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1657203003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1657203003/40001

[commit-bot: I haz the power, 2016-02-03 09:21:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-03 09:22:13]

Description was changed from

==========
Detemplatize SimplifiedBackwardsTextIterator::copyTextTo with
BackwardsTextBuffer

This is the last part of a bigger CL [1], which is in turn part of another even
bigger CL [2].

[1] https://codereview.chromium.org/1647483003
[2] https://codereview.chromium.org/1604783002

BUG=n/a
TEST=n/a; no behavior change
==========

to

==========
Detemplatize SimplifiedBackwardsTextIterator::copyTextTo with
BackwardsTextBuffer

This is the last part of a bigger CL [1], which is in turn part of another even
bigger CL [2].

[1] https://codereview.chromium.org/1647483003
[2] https://codereview.chromium.org/1604783002

BUG=n/a
TEST=n/a; no behavior change

Committed: https://crrev.com/888f85bf9bfc7b8c3d3746d247c87a121a3908f2
Cr-Commit-Position: refs/heads/master@{#373202}
==========

[commit-bot: I haz the power, 2016-02-03 09:22:13]

Patchset 3 (id:??) landed as
https://crrev.com/888f85bf9bfc7b8c3d3746d247c87a121a3908f2
Cr-Commit-Position: refs/heads/master@{#373202}