third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp - Issue 1651263003: Detemplatize TextIterator::copyTextTo with ForwardsTextBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp

Issue 1651263003: Detemplatize TextIterator::copyTextTo with ForwardsTextBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@text_buffers

Patch Set: Change ref parameters to ptrs Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/iterators/CharacterIterator.cpp ('k') | third_party/WebKit/Source/core/editing/iterators/TextIterator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp

diff --git a/third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp b/third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp

index 11ee7e096e9eb7a9c8bc6a28c2e87b1bc1d4f6c2..8f16b63c74f22c9bb4bd7ca4b48d0e097f4521fa 100644

--- a/third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp

+++ b/third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp

@@ -389,7 +389,10 @@ static size_t findPlainTextInternal(CharacterIteratorAlgorithm<Strategy>& it, co

}

while (!it.atEnd()) {

- it.appendTextTo(buffer);

+ // TODO(xiaochengh): Should allow copying text to SearchBuffer directly

+ ForwardsTextBuffer characters;

+ it.copyTextTo(&characters);

+ buffer.append(characters.data(), characters.size());

it.advance(buffer.numberOfCharactersJustAppended());

tryAgain:

size_t matchStartOffset;