third_party/WebKit/Source/web/mac/WebSubstringUtil.mm - Issue 1651263003: Detemplatize TextIterator::copyTextTo with ForwardsTextBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

Issue 1651263003: Detemplatize TextIterator::copyTextTo with ForwardsTextBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@text_buffers

Patch Set: Change ref parameters to ptrs Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

diff --git a/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm b/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

index f3e382c60fa4f928788e6f897db7ad6cc4517cb8..e0045ac683361aed2ad301391175dd0480aa1f4e 100644

--- a/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

+++ b/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

@@ -98,8 +98,8 @@ static NSAttributedString* attributedSubstringFromRange(const EphemeralRange& ra

else

[attrs removeObjectForKey:NSBackgroundColorAttributeName];

- Vector<UChar> characters;

- it.copyTextTo(characters);

+ ForwardsTextBuffer characters;

+ it.copyTextTo(&characters);

NSString* substring =

[[[NSString alloc] initWithCharacters:characters.data()

length:characters.size()] autorelease];

« no previous file with comments | « third_party/WebKit/Source/core/editing/iterators/WordAwareIterator.cpp ('k') | no next file » | no next file with comments »