Issue 164565: Remove WebFrame::selectAll and WebFrame::clearSelection in favor of executeCommand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 164565: Remove WebFrame::selectAll and WebFrame::clearSelection in favor of executeCommand (Closed)

Created:
11 years, 4 months ago by Marshall Greenblatt

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Remove WebFrame::selectAll and WebFrame::clearSelection in favor of having consumers use executeCommand. BUG=19270 TEST=WebFrameTest.GetFullHtmlOfPage

Patch Set 3 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -25 lines)			Patch
M	chrome/renderer/render_view.cc	View	1	4 chunks	+6 lines, -4 lines	0 comments	Download
M	webkit/api/public/WebFrame.h	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	webkit/glue/webframe_impl.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	webkit/glue/webframe_impl.cc	View		2 chunks	+2 lines, -13 lines	0 comments	Download
M	webkit/glue/webframe_unittest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/glue/webview_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

LGTM http://codereview.chromium.org/164565/diff/1004/21 File webkit/api/public/WebFrame.h (right): http://codereview.chromium.org/164565/diff/1004/21#newcode306 Line 306: // See EditorCommand.cpp for the list of ...

11 years, 4 months ago (2009-08-14 17:16:03 UTC) #2

Marshall Greenblatt

On 2009/08/14 17:16:03, darin wrote: > LGTM > > http://codereview.chromium.org/164565/diff/1004/21 > File webkit/api/public/WebFrame.h (right): > ...

11 years, 4 months ago (2009-08-14 17:23:28 UTC) #3

thanks, LGTM

Expand Messages | Collapse Messages

Issue 164565: Remove WebFrame::selectAll and WebFrame::clearSelection in favor of executeCommand (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages