Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Unified Diff: webkit/glue/webframe_impl.cc

Issue 164565: Remove WebFrame::selectAll and WebFrame::clearSelection in favor of executeCommand (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/webframe_impl.h ('k') | webkit/glue/webframe_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webframe_impl.cc
===================================================================
--- webkit/glue/webframe_impl.cc (revision 23431)
+++ webkit/glue/webframe_impl.cc (working copy)
@@ -986,18 +986,6 @@
return frame()->editor()->isContinuousSpellCheckingEnabled();
}
-void WebFrameImpl::selectAll() {
- frame()->selection()->selectAll();
-
- WebViewDelegate* d = GetWebViewImpl()->GetDelegate();
- if (d)
- d->UserMetricsRecordAction(L"SelectAll");
-}
-
-void WebFrameImpl::clearSelection() {
- frame()->selection()->clear();
-}
-
bool WebFrameImpl::hasSelection() const {
// frame()->selection()->isNone() never returns true.
return (frame()->selection()->start() != frame()->selection()->end());
@@ -1134,7 +1122,8 @@
active_match_ = new_selection.toNormalizedRange();
curr_selection_rect = active_match_->boundingBox();
SetMarkerActive(active_match_.get(), true); // Active.
- clearSelection(); // WebKit draws the highlighting for all matches.
+ // WebKit draws the highlighting for all matches.
+ executeCommand(WebString::fromUTF8("Unselect"));
}
if (!options.findNext) {
« no previous file with comments | « webkit/glue/webframe_impl.h ('k') | webkit/glue/webframe_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698