webkit/glue/webframe_unittest.cc - Issue 164565: Remove WebFrame::selectAll and WebFrame::clearSelection in favor of executeCommand

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webkit/glue/webframe_unittest.cc

Issue 164565: Remove WebFrame::selectAll and WebFrame::clearSelection in favor of executeCommand (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: '' Created 11 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « webkit/glue/webframe_impl.cc ('k') | webkit/glue/webview_impl.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/string_util.h"	5 #include "base/string_util.h"

6 #include "testing/gtest/include/gtest/gtest.h"	6 #include "testing/gtest/include/gtest/gtest.h"

7 #include "webkit/api/public/WebData.h"	7 #include "webkit/api/public/WebData.h"

8 #include "webkit/api/public/WebFrame.h"	8 #include "webkit/api/public/WebFrame.h"

9 #include "webkit/api/public/WebString.h"	9 #include "webkit/api/public/WebString.h"

10 #include "webkit/api/public/WebURL.h"	10 #include "webkit/api/public/WebURL.h"

(...skipping 67 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
78 frame->loadHTMLString(html, test_url);	78 frame->loadHTMLString(html, test_url);

79 test_shell_->WaitTestFinished();	79 test_shell_->WaitTestFinished();

80	80

81 EXPECT_EQ(html, UTF16ToUTF8(frame->contentAsMarkup()));	81 EXPECT_EQ(html, UTF16ToUTF8(frame->contentAsMarkup()));

82	82

83 text = frame->contentAsText(std::numeric_limits<size_t>::max());	83 text = frame->contentAsText(std::numeric_limits<size_t>::max());

84 EXPECT_EQ("Hello\n\nWorld", UTF16ToUTF8(text));	84 EXPECT_EQ("Hello\n\nWorld", UTF16ToUTF8(text));

85	85

86 // Test selection check	86 // Test selection check

87 EXPECT_FALSE(frame->hasSelection());	87 EXPECT_FALSE(frame->hasSelection());

88 frame->selectAll();	88 frame->executeCommand(WebString::fromUTF8("SelectAll"));

89 EXPECT_TRUE(frame->hasSelection());	89 EXPECT_TRUE(frame->hasSelection());

90 frame->clearSelection();	90 frame->executeCommand(WebString::fromUTF8("Unselect"));

91 EXPECT_FALSE(frame->hasSelection());	91 EXPECT_FALSE(frame->hasSelection());

92 WebString selection_html = frame->selectionAsMarkup();	92 WebString selection_html = frame->selectionAsMarkup();

93 EXPECT_TRUE(selection_html.isEmpty());	93 EXPECT_TRUE(selection_html.isEmpty());

94 }	94 }

OLD	NEW