Remove WebFrame::selectAll and WebFrame::clearSelection in favor of executeCommand

chrome/renderer/render_view.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/render_view.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 753 matching lines @@
   DCHECK(!devtools_client_.get());
   devtools_client_.reset(new DevToolsClient(this));
 }
 
 void RenderView::OnStopFinding(bool clear_selection) {
   WebView* view = webview();
   if (!view)
     return;
 
   if (clear_selection)
-    view->GetFocusedFrame()->clearSelection();
+    view->GetFocusedFrame()->executeCommand(WebString::fromUTF8("Unselect"));
 
   WebFrame* frame = view->GetMainFrame();
   while (frame) {
     frame->stopFinding(clear_selection);
     frame = view->GetNextFrameAfter(frame, false);
   }
 }
 
 void RenderView::OnFindReplyAck() {
   // Check if there is any queued up request waiting to be sent.
@@ skipping 75 matching lines @@
     return;
 
   webview()->GetFocusedFrame()->executeCommand(WebString::fromUTF8("Delete"));
   UserMetricsRecordAction(L"DeleteSelection");
 }
 
 void RenderView::OnSelectAll() {
   if (!webview())
     return;
 
-  webview()->GetFocusedFrame()->selectAll();
+  webview()->GetFocusedFrame()->executeCommand(
+      WebString::fromUTF8("SelectAll"));
+  UserMetricsRecordAction(L"SelectAll");
 }
 
 void RenderView::OnSetInitialFocus(bool reverse) {
   if (!webview())
     return;
   webview()->SetInitialFocus(reverse);
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 
@@ skipping 1391 matching lines @@
 
   WebRect selection_rect;
   bool result = false;
 
   do {
     result = search_frame->find(
         request_id, search_text, options, wrap_within_frame, &selection_rect);
 
     if (!result) {
       // don't leave text selected as you move to the next frame.
-      search_frame->clearSelection();
+      search_frame->executeCommand(WebString::fromUTF8("Unselect"));
 
       // Find the next frame, but skip the invisible ones.
       do {
         // What is the next frame to search? (we might be going backwards). Note
         // that we specify wrap=true so that search_frame never becomes NULL.
         search_frame = options.forward ?
             webview()->GetNextFrameAfter(search_frame, true) :
             webview()->GetPreviousFrameBefore(search_frame, true);
       } while (!search_frame->hasVisibleContent() &&
                search_frame != focused_frame);
 
       // Make sure selection doesn't affect the search operation in new frame.
-      search_frame->clearSelection();
+      search_frame->executeCommand(WebString::fromUTF8("Unselect"));
 
       // If we have multiple frames and we have wrapped back around to the
       // focused frame, we need to search it once more allowing wrap within
       // the frame, otherwise it will report 'no match' if the focused frame has
       // reported matches, but no frames after the focused_frame contain a
       // match for the search word(s).
       if (multi_frame && search_frame == focused_frame) {
         result = search_frame->find(
             request_id, search_text, options, true,  // Force wrapping.
             &selection_rect);
@@ skipping 1010 matching lines @@
     Send(new ViewHostMsg_PasswordFormsSeen(routing_id_, password_forms));
 }
 
 void RenderView::Print(WebFrame* frame, bool script_initiated) {
   DCHECK(frame);
   if (print_helper_.get() == NULL) {
     print_helper_.reset(new PrintWebViewHelper(this));
   }
   print_helper_->Print(frame, script_initiated);
 }