Remove WebFrame::selectAll and WebFrame::clearSelection in favor of executeCommand

webkit/glue/webframe_impl.cc

 /*
  * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
  * Copyright (C) 2006 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 968 matching lines @@
 void WebFrameImpl::enableContinuousSpellChecking(bool enable) {
   if (enable == isContinuousSpellCheckingEnabled())
     return;
   frame()->editor()->toggleContinuousSpellChecking();
 }
 
 bool WebFrameImpl::isContinuousSpellCheckingEnabled() const {
   return frame()->editor()->isContinuousSpellCheckingEnabled();
 }
 
-void WebFrameImpl::selectAll() {
-  frame()->selection()->selectAll();
-
-  WebViewDelegate* d = GetWebViewImpl()->GetDelegate();
-  if (d)
-    d->UserMetricsRecordAction(L"SelectAll");
-}
-
-void WebFrameImpl::clearSelection() {
-  frame()->selection()->clear();
-}
-
 bool WebFrameImpl::hasSelection() const {
   // frame()->selection()->isNone() never returns true.
   return (frame()->selection()->start() != frame()->selection()->end());
 }
 
 WebRange WebFrameImpl::selectionRange() const {
   return webkit_glue::RangeToWebRange(
       frame()->selection()->toNormalizedRange());
 }
 
@@ skipping 116 matching lines @@
     // be active but we still continue searching. This matches Safari's
     // behavior, including some oddities when selectable and un-selectable text
     // are mixed on a page: see https://bugs.webkit.org/show_bug.cgi?id=19127.
     if (new_selection.isNone() ||
         (new_selection.start() == new_selection.end())) {
       active_match_ = NULL;
     } else {
       active_match_ = new_selection.toNormalizedRange();
       curr_selection_rect = active_match_->boundingBox();
       SetMarkerActive(active_match_.get(), true);  // Active.
-      clearSelection();  // WebKit draws the highlighting for all matches.
+      // WebKit draws the highlighting for all matches.
+      executeCommand(WebString::fromUTF8("Unselect"));
     }
 
     if (!options.findNext) {
       // This is a Find operation, so we set the flag to ask the scoping effort
       // to find the active rect for us so we can update the ordinal (n of m).
       locating_active_rect_ = true;
     } else {
       if (old_active_frame != this) {
         // If the active frame has changed it means that we have a multi-frame
         // page and we just switch to searching in a new frame. Then we just
@@ skipping 713 matching lines @@
 
   SecurityOrigin* security_origin = frame_->document()->securityOrigin();
 
   if (!frame_->loader()->isScheduledLocationChangePending()) {
     frame_->loader()->stopAllLoaders();
     frame_->loader()->begin(frame_->loader()->url(), true, security_origin);
     frame_->loader()->write(script_result);
     frame_->loader()->end();
   }
 }