Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Side by Side Diff: webkit/glue/webview_impl.cc

Issue 164565: Remove WebFrame::selectAll and WebFrame::clearSelection in favor of executeCommand (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/glue/webframe_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2007-2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2007-2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "build/build_config.h" 6 #include "build/build_config.h"
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 MSVC_PUSH_WARNING_LEVEL(0); 9 MSVC_PUSH_WARNING_LEVEL(0);
10 #include "CSSStyleSelector.h" 10 #include "CSSStyleSelector.h"
(...skipping 802 matching lines...) Expand 10 before | Expand all | Expand 10 after
813 VKEY_PRIOR : VKEY_NEXT); 813 VKEY_PRIOR : VKEY_NEXT);
814 return ScrollViewWithKeyboard(key_code); 814 return ScrollViewWithKeyboard(key_code);
815 } 815 }
816 break; 816 break;
817 } 817 }
818 818
819 case WebInputEvent::RawKeyDown: { 819 case WebInputEvent::RawKeyDown: {
820 if (event.modifiers == WebInputEvent::ControlKey) { 820 if (event.modifiers == WebInputEvent::ControlKey) {
821 switch (event.windowsKeyCode) { 821 switch (event.windowsKeyCode) {
822 case 'A': 822 case 'A':
823 GetFocusedFrame()->selectAll(); 823 GetFocusedFrame()->executeCommand(WebString::fromUTF8("SelectAll"));
824 return true; 824 return true;
825 case VKEY_INSERT: 825 case VKEY_INSERT:
826 case 'C': 826 case 'C':
827 GetFocusedFrame()->executeCommand(WebString::fromUTF8("Copy")); 827 GetFocusedFrame()->executeCommand(WebString::fromUTF8("Copy"));
828 return true; 828 return true;
829 // Match FF behavior in the sense that Ctrl+home/end are the only Ctrl 829 // Match FF behavior in the sense that Ctrl+home/end are the only Ctrl
830 // key combinations which affect scrolling. Safari is buggy in the 830 // key combinations which affect scrolling. Safari is buggy in the
831 // sense that it scrolls the page for all Ctrl+scrolling key 831 // sense that it scrolls the page for all Ctrl+scrolling key
832 // combinations. For e.g. Ctrl+pgup/pgdn/up/down, etc. 832 // combinations. For e.g. Ctrl+pgup/pgdn/up/down, etc.
833 case VKEY_HOME: 833 case VKEY_HOME:
(...skipping 1110 matching lines...) Expand 10 before | Expand all | Expand 10 after
1944 1944
1945 return document->focusedNode(); 1945 return document->focusedNode();
1946 } 1946 }
1947 1947
1948 HitTestResult WebViewImpl::HitTestResultForWindowPos(const IntPoint& pos) { 1948 HitTestResult WebViewImpl::HitTestResultForWindowPos(const IntPoint& pos) {
1949 IntPoint doc_point( 1949 IntPoint doc_point(
1950 page_->mainFrame()->view()->windowToContents(pos)); 1950 page_->mainFrame()->view()->windowToContents(pos));
1951 return page_->mainFrame()->eventHandler()-> 1951 return page_->mainFrame()->eventHandler()->
1952 hitTestResultAtPoint(doc_point, false); 1952 hitTestResultAtPoint(doc_point, false);
1953 } 1953 }
OLDNEW
« no previous file with comments | « webkit/glue/webframe_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698