Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1642223002: Delete selection gap code. (Closed)

Created:
4 years, 10 months ago by wkorman
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), jbroman, jchaffraix+rendering, Justin Novosad, kinuko+watch, leviw+renderwatch, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, vmpstr+blinkwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete selection gap code. Selection gaps have been disabled in M47 stable for some time now. BUG=471908 Committed: https://crrev.com/47eac956a56541cd7fc241929b37618148568c05 Cr-Commit-Position: refs/heads/master@{#372220}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Integrate feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -587 lines) Patch
M third_party/WebKit/LayoutTests/paint/selection/resources/selection.js View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBR.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 2 chunks +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 3 chunks +0 lines, -279 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h View 1 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 12 chunks +1 line, -53 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/RootInlineBox.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp View 1 chunk +0 lines, -53 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BlockFlowPainter.cpp View 1 chunk +0 lines, -41 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BlockPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.h View 3 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 chunk +0 lines, -87 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
wkorman
4 years, 10 months ago (2016-01-28 21:55:54 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642223002/1
4 years, 10 months ago (2016-01-28 21:57:40 UTC) #5
chrishtr
https://codereview.chromium.org/1642223002/diff/1/third_party/WebKit/Source/core/layout/LayoutBR.cpp File third_party/WebKit/Source/core/layout/LayoutBR.cpp (left): https://codereview.chromium.org/1642223002/diff/1/third_party/WebKit/Source/core/layout/LayoutBR.cpp#oldcode48 third_party/WebKit/Source/core/layout/LayoutBR.cpp:48: if (!RuntimeEnabledFeatures::selectionPaintingWithoutSelectionGapsEnabled()) Why was this a negation of the ...
4 years, 10 months ago (2016-01-28 22:06:22 UTC) #6
wkorman
https://codereview.chromium.org/1642223002/diff/1/third_party/WebKit/Source/core/layout/LayoutBR.cpp File third_party/WebKit/Source/core/layout/LayoutBR.cpp (left): https://codereview.chromium.org/1642223002/diff/1/third_party/WebKit/Source/core/layout/LayoutBR.cpp#oldcode48 third_party/WebKit/Source/core/layout/LayoutBR.cpp:48: if (!RuntimeEnabledFeatures::selectionPaintingWithoutSelectionGapsEnabled()) On 2016/01/28 at 22:06:22, chrishtr wrote: > ...
4 years, 10 months ago (2016-01-28 22:54:32 UTC) #7
chrishtr
lgtm
4 years, 10 months ago (2016-01-28 23:00:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642223002/20001
4 years, 10 months ago (2016-01-28 23:00:38 UTC) #10
leviw_travelin_and_unemployed
\O/ LGTM!
4 years, 10 months ago (2016-01-28 23:23:26 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-29 00:35:36 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 00:36:35 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/47eac956a56541cd7fc241929b37618148568c05
Cr-Commit-Position: refs/heads/master@{#372220}

Powered by Google App Engine
This is Rietveld 408576698