third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp - Issue 1642223002: Delete selection gap code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp

Issue 1642223002: Delete selection gap code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Integrate feedback. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp b/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp

index fb2c6b4dde11b23696458d858508fcebee0a205a..5e5123db2e487057599811ab969cfed7dc10f4c4 100644

--- a/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp

+++ b/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp

@@ -195,8 +195,7 @@ bool InlineTextBox::hasWrappedSelectionNewline() const

return false;

SelectionState state = selectionState();

- return RuntimeEnabledFeatures::selectionPaintingWithoutSelectionGapsEnabled()

- && (state == SelectionStart || state == SelectionInside)

+ return (state == SelectionStart || state == SelectionInside)

// Checking last leaf child can be slow, so we make sure to do this only

// after the other simple conditionals.

&& (root().lastLeafChild() == this)