Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1350973003: Invalidate line break selection rects when selected. (Closed)

Created:
5 years, 3 months ago by wkorman
Modified:
5 years, 3 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Invalidate line break selection rects when selected. BUG=474759 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202556

Patch Set 1 #

Patch Set 2 : Preserve prior LayoutBR selection rect behavior when REF is off. #

Total comments: 3

Patch Set 3 : Don't need redundant early-out for selection rect. #

Messages

Total messages: 14 (5 generated)
wkorman
https://codereview.chromium.org/1350973003/diff/20001/LayoutTests/paint/selection/invalidation-rect-with-br-includes-newline-expected.txt File LayoutTests/paint/selection/invalidation-rect-with-br-includes-newline-expected.txt (right): https://codereview.chromium.org/1350973003/diff/20001/LayoutTests/paint/selection/invalidation-rect-with-br-includes-newline-expected.txt#newcode9 LayoutTests/paint/selection/invalidation-rect-with-br-includes-newline-expected.txt:9: [24, 8, 16, 16], Without this change, this line ...
5 years, 3 months ago (2015-09-18 20:44:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350973003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350973003/20001
5 years, 3 months ago (2015-09-18 20:54:51 UTC) #4
chrishtr
https://codereview.chromium.org/1350973003/diff/20001/Source/core/layout/LayoutBR.cpp File Source/core/layout/LayoutBR.cpp (right): https://codereview.chromium.org/1350973003/diff/20001/Source/core/layout/LayoutBR.cpp#newcode54 Source/core/layout/LayoutBR.cpp:54: return (selectionState() == SelectionNone) ? LayoutRect() Return LayoutText::selectionRectForPaintInvalidation(paintInvalidationContainer) unconditionally, ...
5 years, 3 months ago (2015-09-18 21:08:03 UTC) #5
wkorman
https://codereview.chromium.org/1350973003/diff/20001/Source/core/layout/LayoutBR.cpp File Source/core/layout/LayoutBR.cpp (right): https://codereview.chromium.org/1350973003/diff/20001/Source/core/layout/LayoutBR.cpp#newcode54 Source/core/layout/LayoutBR.cpp:54: return (selectionState() == SelectionNone) ? LayoutRect() On 2015/09/18 at ...
5 years, 3 months ago (2015-09-18 21:26:57 UTC) #6
chrishtr
lgtm
5 years, 3 months ago (2015-09-18 21:27:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350973003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350973003/40001
5 years, 3 months ago (2015-09-18 21:27:47 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/109598)
5 years, 3 months ago (2015-09-18 23:35:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350973003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350973003/40001
5 years, 3 months ago (2015-09-18 23:50:44 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-19 00:43:26 UTC) #14
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202556

Powered by Google App Engine
This is Rietveld 408576698