third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp - Issue 1642223002: Delete selection gap code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

Issue 1642223002: Delete selection gap code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Integrate feedback. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp b/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

index 4072a8092a1b4ef037fd45362e6c292e24977def..cb0a8e76787d0599c9aa8e854dbea59b226d63e2 100644

--- a/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

@@ -258,9 +258,7 @@ bool InlineTextBoxPainter::shouldPaintTextBox(const PaintInfo& paintInfo)

// This code path is only called in PaintPhaseForeground whereas we would

// expect PaintPhaseSelection. The existing haveSelection logic in paint()

// tests for != PaintPhaseTextClip.

- bool paintLineBreaks = RuntimeEnabledFeatures::selectionPaintingWithoutSelectionGapsEnabled();

- if ((!paintLineBreaks && m_inlineTextBox.isLineBreak())

- || m_inlineTextBox.lineLayoutItem().style()->visibility() != VISIBLE

+ if (m_inlineTextBox.lineLayoutItem().style()->visibility() != VISIBLE

|| m_inlineTextBox.truncation() == cFullTruncation

|| !m_inlineTextBox.len())

return false;