Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 1642223002: Delete selection gap code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Integrate feedback. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 355 matching lines...) Expand 10 before | Expand all | Expand 10 after
366 366
367 quadForFakeMouseMoveEvent = paintInvalidationContainer.localToAbsoluteQuad(q uadForFakeMouseMoveEvent); 367 quadForFakeMouseMoveEvent = paintInvalidationContainer.localToAbsoluteQuad(q uadForFakeMouseMoveEvent);
368 frame->eventHandler().dispatchFakeMouseMoveEventSoonInQuad(quadForFakeMouseM oveEvent); 368 frame->eventHandler().dispatchFakeMouseMoveEventSoonInQuad(quadForFakeMouseM oveEvent);
369 369
370 bool requiresPaintInvalidation = true; 370 bool requiresPaintInvalidation = true;
371 371
372 if (box().view()->compositor()->inCompositingMode()) { 372 if (box().view()->compositor()->inCompositingMode()) {
373 bool onlyScrolledCompositedLayers = scrollsOverflow() 373 bool onlyScrolledCompositedLayers = scrollsOverflow()
374 && !layer()->hasVisibleNonLayerContent() 374 && !layer()->hasVisibleNonLayerContent()
375 && !layer()->hasNonCompositedChild() 375 && !layer()->hasNonCompositedChild()
376 && !layer()->hasBlockSelectionGapBounds()
377 && box().style()->backgroundLayers().attachment() != LocalBackground Attachment; 376 && box().style()->backgroundLayers().attachment() != LocalBackground Attachment;
378 377
379 if (usesCompositedScrolling() || onlyScrolledCompositedLayers) 378 if (usesCompositedScrolling() || onlyScrolledCompositedLayers)
380 requiresPaintInvalidation = false; 379 requiresPaintInvalidation = false;
381 } 380 }
382 381
383 // Only the root layer can overlap non-composited fixed-position elements. 382 // Only the root layer can overlap non-composited fixed-position elements.
384 if (!requiresPaintInvalidation && layer()->isRootLayer() && frameView->hasVi ewportConstrainedObjects()) { 383 if (!requiresPaintInvalidation && layer()->isRootLayer() && frameView->hasVi ewportConstrainedObjects()) {
385 if (!frameView->invalidateViewportConstrainedObjects()) 384 if (!frameView->invalidateViewportConstrainedObjects())
386 requiresPaintInvalidation = true; 385 requiresPaintInvalidation = true;
(...skipping 1160 matching lines...) Expand 10 before | Expand all | Expand 10 after
1547 } 1546 }
1548 1547
1549 DEFINE_TRACE(PaintLayerScrollableArea::ScrollbarManager) 1548 DEFINE_TRACE(PaintLayerScrollableArea::ScrollbarManager)
1550 { 1549 {
1551 visitor->trace(m_scrollableArea); 1550 visitor->trace(m_scrollableArea);
1552 visitor->trace(m_hBar); 1551 visitor->trace(m_hBar);
1553 visitor->trace(m_vBar); 1552 visitor->trace(m_vBar);
1554 } 1553 }
1555 1554
1556 } // namespace blink 1555 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayer.cpp ('k') | third_party/WebKit/Source/core/testing/Internals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698