Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp

Issue 1642223002: Delete selection gap code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Integrate feedback. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp b/third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp
index 66e6df351ef7b3b0ccf394fa8fbace30e4a2dbae..3e6a0cbe219112fc8fadb2918080182aa6ae92f9 100644
--- a/third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp
@@ -54,9 +54,6 @@ void ListMarkerPainter::paint(const PaintInfo& paintInfo, const LayoutPoint& pai
LayoutPoint boxOrigin(paintOffset + m_layoutListMarker.location());
LayoutRect overflowRect(m_layoutListMarker.visualOverflowRect());
- if (!RuntimeEnabledFeatures::selectionPaintingWithoutSelectionGapsEnabled()
- && m_layoutListMarker.selectionState() != SelectionNone)
- overflowRect.unite(m_layoutListMarker.localSelectionRect());
overflowRect.moveBy(boxOrigin);
IntRect pixelSnappedOverflowRect = pixelSnappedIntRect(overflowRect);
@@ -83,13 +80,6 @@ void ListMarkerPainter::paint(const PaintInfo& paintInfo, const LayoutPoint& pai
return;
}
- if (!RuntimeEnabledFeatures::selectionPaintingWithoutSelectionGapsEnabled()
- && m_layoutListMarker.selectionState() != SelectionNone) {
- LayoutRect selRect = m_layoutListMarker.localSelectionRect();
- selRect.moveBy(boxOrigin);
- context.fillRect(pixelSnappedIntRect(selRect), m_layoutListMarker.listItem()->selectionBackgroundColor());
- }
-
LayoutListMarker::ListStyleCategory styleCategory = m_layoutListMarker.listStyleCategory();
if (styleCategory == LayoutListMarker::ListStyleCategory::None)
return;
« no previous file with comments | « third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698