Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 1641413002: Makes GetBuildTime behave identically on all build types. (Closed)

Created:
4 years, 10 months ago by Zachary Forman
Modified:
4 years, 10 months ago
CC:
chromium-reviews, mithro-old, Sébastien Marchand, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes GetBuildTime behave sanely on all build types. After discussion with maruel and agl, it seems that (1) for the purposes of build determinism, it's necessary to be able to arbitrarily set the build time. (2) for the purposes of continuous integration, longer duration between cache invalidation is better, but >=1mo is preferable. (3) for security purposes, timebombs would ideally be as close to the actual time of the build as possible. It must be in the past. (4) HSTS certificate pinning is valid for 70 days. To make CI builds enforce HTST pinning, <=1mo is preferable. All of these can reasonably be satisfied by using different settings for CI versus official builds: - For official build, the build time is set to 5:00am of the day of the build or the day before. - For continuous integration build, the build time is set to the current month. If the current day is within the first week of the month and last Sunday wasn't part of the current month, the Sunday of the previous month is used. This results that cache invalidation happens on a Sunday, which is preferable from an infrastructure standpoint. - In the case that the build time needs to be set to a specific value (i.e. to reproduce a build), the GN/GYP variable 'override_build_date' can be used to set the BUILD_DATE explicitly. Its format is "Mmm DD YYYY". The way it is done is: - Generate $target_gen_dir/generated_build_date.h that defines BUILD_DATE. Its value depends on if an official build is done or not. - This step depends on build/util/LASTCHANGE so it is run at every sync. The file is only touched if the content changed to not affect null build. Most importantly, this change removes the need of both GN/GYP variable "dont_embed_build_metadata" and C define "DONT_EMBED_BUILD_METADATA"; the build is always deterministic (up to a month) by default. This removes the risk oversight of forgetting to set this variable, which already happened. R=maruel@chromium.org BUG=489490 Committed: https://crrev.com/08d91b75212b6592f05ff993d5a71c0f5a546563 Cr-Commit-Position: refs/heads/master@{#375136}

Patch Set 1 #

Patch Set 2 : Removes other checks #

Patch Set 3 : Follows rename. #

Total comments: 17

Patch Set 4 : Uses python to generate header #

Patch Set 5 : And adds the necessary config to gyp... #

Patch Set 6 : Fixed bad input #

Total comments: 19

Patch Set 7 : Responses to comments #

Patch Set 8 : Tests for build time < now invariant #

Patch Set 9 : Addresses Merge Conflicts #

Total comments: 21

Patch Set 10 : Python tidyup, response to comments #

Patch Set 11 : Hook based approach #

Total comments: 6

Patch Set 12 : Go back to gn/ninja solution. Remove instances of dont_use_build_metadata. #

Patch Set 13 : Go back to gn/ninja solution. Remove instances of dont_use_build_metadata. #

Total comments: 12

Patch Set 14 : Response to comments #

Total comments: 4

Patch Set 15 : Response to dpranke's comments (#79) #

Patch Set 16 : Adds missing dependency to base_nacl and co #

Patch Set 17 : Possible fix for windows build error #

Total comments: 9

Patch Set 18 : Addresses comments (#85-#89) #

Total comments: 4

Patch Set 19 : Response to comments + fixes gyp build error. #

Total comments: 12

Patch Set 20 : Response to #96 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -105 lines) Patch
M base/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +32 lines, -0 lines 0 comments Download
M base/base.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 3 chunks +31 lines, -0 lines 0 comments Download
M base/base_nacl.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +4 lines, -0 lines 0 comments Download
M base/build_time.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +10 lines, -8 lines 0 comments Download
M base/build_time.cc View 1 2 3 4 5 6 7 8 9 2 chunks +6 lines, -11 lines 0 comments Download
M base/build_time_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +7 lines, -15 lines 0 comments Download
M build/common.gypi View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +2 lines, -18 lines 0 comments Download
M build/config/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +0 lines, -4 lines 0 comments Download
M build/config/build_metadata.gni View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +0 lines, -18 lines 0 comments Download
M build/config/posix/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 2 chunks +1 line, -9 lines 1 comment Download
A build/write_build_date_header.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +97 lines, -0 lines 0 comments Download
M components/ssl_errors/error_classification.cc View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -8 lines 0 comments Download
M net/cert/ct_policy_enforcer.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M net/http/transport_security_state.cc View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M tools/mb/mb_config.pyl View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 118 (19 generated)
Zachary Forman
Hey all - could you please take a look at this CL? Thanks, Zac
4 years, 10 months ago (2016-01-29 08:20:41 UTC) #3
agl
https://codereview.chromium.org/1641413002/diff/40001/base/build_time.h File base/build_time.h (right): https://codereview.chromium.org/1641413002/diff/40001/base/build_time.h#newcode14 base/build_time.h:14: // rounded to midnight at the start of the ...
4 years, 10 months ago (2016-01-29 21:46:46 UTC) #4
M-A Ruel
https://codereview.chromium.org/1641413002/diff/40001/base/BUILD.gn File base/BUILD.gn (right): https://codereview.chromium.org/1641413002/diff/40001/base/BUILD.gn#newcode30 base/BUILD.gn:30: override_build_date = "N/A" What about: - By default override_build_date ...
4 years, 10 months ago (2016-01-30 02:58:14 UTC) #5
Zachary Forman
I've modified this CL to use a python script to generate a build date based ...
4 years, 10 months ago (2016-02-01 07:28:31 UTC) #7
M-A Ruel
There's also third_party/yasm/CHROMIUM.diff that references DONT_EMBED_BUILD_METADATA. This means we'll have to update this third party. ...
4 years, 10 months ago (2016-02-01 17:52:29 UTC) #9
lgarron
I'm excited to have clock interstitial working in local builds! :-D IsUserClockInThePast() can definitely use ...
4 years, 10 months ago (2016-02-02 04:03:11 UTC) #11
Zachary Forman
On 2016/02/02 at 04:03:11, lgarron wrote: > I'm excited to have clock interstitial working in ...
4 years, 10 months ago (2016-02-02 06:22:50 UTC) #12
Zachary Forman
https://codereview.chromium.org/1641413002/diff/100001/base/BUILD.gn File base/BUILD.gn (right): https://codereview.chromium.org/1641413002/diff/100001/base/BUILD.gn#newcode1996 base/BUILD.gn:1996: args += [ "--override" ] On 2016/02/01 at 17:52:28, ...
4 years, 10 months ago (2016-02-02 06:30:38 UTC) #13
lgarron
https://codereview.chromium.org/1641413002/diff/100001/base/build_time.h File base/build_time.h (right): https://codereview.chromium.org/1641413002/diff/100001/base/build_time.h#newcode19 base/build_time.h:19: // This value should only be considered accurate to ...
4 years, 10 months ago (2016-02-02 19:38:30 UTC) #14
felt
lgtm per lgarron
4 years, 10 months ago (2016-02-03 15:26:23 UTC) #15
M-A Ruel
+laforge for incremental build on official build +dpranke for the idea below Sorry for taking ...
4 years, 10 months ago (2016-02-04 15:24:13 UTC) #17
Nico
I don't understand the "this is a generated file, so it doesn't trigger a rebuild" ...
4 years, 10 months ago (2016-02-04 15:28:16 UTC) #18
M-A Ruel
On 2016/02/04 15:28:16, Nico wrote: > I don't understand the "this is a generated file, ...
4 years, 10 months ago (2016-02-04 15:30:31 UTC) #19
Nico
On 2016/02/04 15:30:31, M-A Ruel wrote: > On 2016/02/04 15:28:16, Nico wrote: > > I ...
4 years, 10 months ago (2016-02-04 15:37:35 UTC) #20
M-A Ruel
On 2016/02/04 15:37:35, Nico wrote: > On 2016/02/04 15:30:31, M-A Ruel wrote: > > On ...
4 years, 10 months ago (2016-02-04 15:41:22 UTC) #21
Nico
oh, that's no good then, i agree.
4 years, 10 months ago (2016-02-04 15:46:32 UTC) #22
laforge
https://codereview.chromium.org/1641413002/diff/160001/base/build_time.h File base/build_time.h (right): https://codereview.chromium.org/1641413002/diff/160001/base/build_time.h#newcode17 base/build_time.h:17: // changes. However, official builds will always be built ...
4 years, 10 months ago (2016-02-04 15:50:19 UTC) #23
Zachary Forman
Thanks for all the Python advice! Hopefully looking a lot better now :) https://codereview.chromium.org/1641413002/diff/160001/build/write_build_date_header.py File ...
4 years, 10 months ago (2016-02-04 22:29:12 UTC) #24
Dirk Pranke
I don't think I understand what problem we're trying to solve, but the approach that ...
4 years, 10 months ago (2016-02-04 22:32:22 UTC) #26
Nico
What this CL is trying to do is this: We currently use __DATE__. That's bad ...
4 years, 10 months ago (2016-02-04 22:35:31 UTC) #27
Zachary Forman
https://codereview.chromium.org/1641413002/diff/160001/base/build_time.cc File base/build_time.cc (right): https://codereview.chromium.org/1641413002/diff/160001/base/build_time.cc#newcode18 base/build_time.cc:18: const char kDateTime[] = BUILD_DATE " 00:00:00"; On 2016/02/04 ...
4 years, 10 months ago (2016-02-04 22:39:26 UTC) #29
Zachary Forman
On 2016/02/04 at 22:39:25, Zachary Forman wrote: > zforman@google.com changed reviewers: > - brettw@chromium.org This ...
4 years, 10 months ago (2016-02-04 22:40:19 UTC) #31
Zachary Forman
On 2016/02/04 at 22:35:31, thakis wrote: > What this CL is trying to do is ...
4 years, 10 months ago (2016-02-04 22:43:54 UTC) #32
brettw
This function is used for error classification and not actually detecting errors right? I wouldn't ...
4 years, 10 months ago (2016-02-04 22:51:33 UTC) #33
lgarron
On 2016/02/04 at 22:51:33, brettw wrote: > This function is used for error classification and ...
4 years, 10 months ago (2016-02-04 22:54:06 UTC) #34
Dirk Pranke
On 2016/02/04 22:43:54, Zachary Forman wrote: > On 2016/02/04 at 22:35:31, thakis wrote: > > ...
4 years, 10 months ago (2016-02-04 22:56:15 UTC) #35
Nico
On 2016/02/04 22:56:15, Dirk Pranke wrote: > On 2016/02/04 22:43:54, Zachary Forman wrote: > > ...
4 years, 10 months ago (2016-02-04 23:00:09 UTC) #36
Dirk Pranke
On 2016/02/04 22:54:06, lgarron wrote: > On 2016/02/04 at 22:51:33, brettw wrote: > > This ...
4 years, 10 months ago (2016-02-04 23:00:31 UTC) #37
Dirk Pranke
On 2016/02/04 23:00:09, Nico wrote: > On 2016/02/04 22:56:15, Dirk Pranke wrote: > > On ...
4 years, 10 months ago (2016-02-04 23:01:31 UTC) #38
Zachary Forman
On 2016/02/04 at 23:01:31, dpranke wrote: > On 2016/02/04 23:00:09, Nico wrote: > > On ...
4 years, 10 months ago (2016-02-04 23:08:33 UTC) #39
brettw
On 2016/02/04 23:08:33, Zachary Forman wrote: > Could we not set it either via gn ...
4 years, 10 months ago (2016-02-04 23:17:47 UTC) #40
M-A Ruel
On 2016/02/04 23:17:47, brettw wrote: > On 2016/02/04 23:08:33, Zachary Forman wrote: > > Could ...
4 years, 10 months ago (2016-02-04 23:25:29 UTC) #41
Zachary Forman
On 2016/02/04 at 23:25:29, maruel wrote: > On 2016/02/04 23:17:47, brettw wrote: > > On ...
4 years, 10 months ago (2016-02-04 23:29:29 UTC) #42
Dirk Pranke
I would be inclined to just use the same code path for both; I find ...
4 years, 10 months ago (2016-02-04 23:48:12 UTC) #43
M-A Ruel
On 2016/02/04 23:29:29, Zachary Forman wrote: > On 2016/02/04 at 23:25:29, maruel wrote: > > ...
4 years, 10 months ago (2016-02-05 00:20:47 UTC) #44
Dirk Pranke
On 2016/02/05 00:20:47, M-A Ruel wrote: > On 2016/02/04 23:48:12, Dirk Pranke wrote: > > ...
4 years, 10 months ago (2016-02-05 00:25:48 UTC) #45
Zachary Forman
On 2016/02/05 at 00:25:48, dpranke wrote: > On 2016/02/05 00:20:47, M-A Ruel wrote: > > ...
4 years, 10 months ago (2016-02-05 00:31:48 UTC) #46
Dirk Pranke
On 2016/02/05 00:31:48, Zachary Forman wrote: > On 2016/02/05 at 00:25:48, dpranke wrote: > > ...
4 years, 10 months ago (2016-02-05 00:33:50 UTC) #47
Zachary Forman
On 2016/02/05 at 00:33:50, dpranke wrote: > On 2016/02/05 00:31:48, Zachary Forman wrote: > > ...
4 years, 10 months ago (2016-02-05 02:20:50 UTC) #48
Dirk Pranke
On 2016/02/05 02:20:50, Zachary Forman wrote: > I think the other concern with just taking ...
4 years, 10 months ago (2016-02-05 02:57:59 UTC) #49
Zachary Forman
On 2016/02/05 at 02:57:59, dpranke wrote: > On 2016/02/05 02:20:50, Zachary Forman wrote: > > ...
4 years, 10 months ago (2016-02-05 03:06:12 UTC) #50
Nico
On 2016/02/05 03:06:12, Zachary Forman wrote: > On 2016/02/05 at 02:57:59, dpranke wrote: > > ...
4 years, 10 months ago (2016-02-05 15:48:49 UTC) #51
M-A Ruel
On 2016/02/05 15:48:49, Nico wrote: > Is that a problem? It seems to update pretty ...
4 years, 10 months ago (2016-02-05 18:37:37 UTC) #52
Nico
On 2016/02/05 18:37:37, M-A Ruel wrote: > On 2016/02/05 15:48:49, Nico wrote: > > Is ...
4 years, 10 months ago (2016-02-05 18:39:10 UTC) #53
M-A Ruel
On 2016/02/05 18:39:10, Nico wrote: > On 2016/02/05 18:37:37, M-A Ruel wrote: > > On ...
4 years, 10 months ago (2016-02-05 18:41:06 UTC) #54
M-A Ruel
On 2016/02/05 18:41:06, M-A Ruel wrote: > On 2016/02/05 18:39:10, Nico wrote: > > On ...
4 years, 10 months ago (2016-02-05 18:41:21 UTC) #55
Nico
Zero knobs would be nicer is all I'm saying :-) Can you forward me the ...
4 years, 10 months ago (2016-02-05 18:43:15 UTC) #56
M-A Ruel
On 2016/02/05 18:43:15, Nico wrote: > Zero knobs would be nicer is all I'm saying ...
4 years, 10 months ago (2016-02-05 18:53:50 UTC) #57
Dirk Pranke
On 2016/02/05 18:53:50, M-A Ruel wrote: > On 2016/02/05 18:43:15, Nico wrote: > > Zero ...
4 years, 10 months ago (2016-02-05 18:59:50 UTC) #58
M-A Ruel
On 2016/02/05 18:59:50, Dirk Pranke wrote: > On 2016/02/05 18:53:50, M-A Ruel wrote: > > ...
4 years, 10 months ago (2016-02-05 19:10:23 UTC) #59
Nico
On 2016/02/05 19:10:23, M-A Ruel wrote: > On 2016/02/05 18:59:50, Dirk Pranke wrote: > > ...
4 years, 10 months ago (2016-02-05 19:12:34 UTC) #60
M-A Ruel
But I think patchset #3 is fine as a hook, no need for something more ...
4 years, 10 months ago (2016-02-05 19:16:37 UTC) #61
Dirk Pranke
On 2016/02/05 19:10:23, M-A Ruel wrote: > On 2016/02/05 18:59:50, Dirk Pranke wrote: > > ...
4 years, 10 months ago (2016-02-05 19:39:08 UTC) #62
M-A Ruel
On 2016/02/05 19:39:08, Dirk Pranke wrote: > On 2016/02/05 19:10:23, M-A Ruel wrote: > > ...
4 years, 10 months ago (2016-02-05 19:43:54 UTC) #63
lgarron
On 2016/02/05 at 19:43:54, maruel wrote: > On 2016/02/05 19:39:08, Dirk Pranke wrote: > > ...
4 years, 10 months ago (2016-02-05 19:58:00 UTC) #64
Nico
On 2016/02/05 19:58:00, lgarron wrote: > On 2016/02/05 at 19:43:54, maruel wrote: > > On ...
4 years, 10 months ago (2016-02-05 20:03:37 UTC) #65
lgarron
On 2016/02/05 at 20:03:37, thakis wrote: > On 2016/02/05 19:58:00, lgarron wrote: > > On ...
4 years, 10 months ago (2016-02-05 20:09:09 UTC) #66
Nico
On 2016/02/05 20:09:09, lgarron wrote: > On 2016/02/05 at 20:03:37, thakis wrote: > > On ...
4 years, 10 months ago (2016-02-05 20:11:02 UTC) #67
lgarron
On 2016/02/05 at 20:11:02, thakis wrote: > On 2016/02/05 20:09:09, lgarron wrote: > > On ...
4 years, 10 months ago (2016-02-05 20:23:24 UTC) #68
Dirk Pranke
On 2016/02/05 20:23:24, lgarron wrote: > On 2016/02/05 at 20:11:02, thakis wrote: > > On ...
4 years, 10 months ago (2016-02-05 20:36:13 UTC) #69
lgarron
On 2016/02/05 at 20:36:13, dpranke wrote: > On 2016/02/05 20:23:24, lgarron wrote: > > On ...
4 years, 10 months ago (2016-02-05 20:38:36 UTC) #70
Nico
> It is fair to try and design a solution that works for a wide ...
4 years, 10 months ago (2016-02-05 21:14:14 UTC) #71
M-A Ruel
> I never did see an answer to my original observation and question, though, which ...
4 years, 10 months ago (2016-02-06 02:24:37 UTC) #72
Dirk Pranke
On 2016/02/06 02:24:37, M-A Ruel wrote: > > I never did see an answer to ...
4 years, 10 months ago (2016-02-06 17:39:01 UTC) #73
M-A Ruel
On 2016/02/06 17:39:01, Dirk Pranke wrote: > > And not committing this leaves us in ...
4 years, 10 months ago (2016-02-08 01:26:37 UTC) #74
Zachary Forman
Alright, so based on the discussion I've made a new patchset based on the gn/gyp ...
4 years, 10 months ago (2016-02-09 00:02:05 UTC) #75
M-A Ruel
looks great, few nits. https://codereview.chromium.org/1641413002/diff/240001/base/BUILD.gn File base/BUILD.gn (right): https://codereview.chromium.org/1641413002/diff/240001/base/BUILD.gn#newcode1894 base/BUILD.gn:1894: "//build/util/LASTCHANGE", This is even better. ...
4 years, 10 months ago (2016-02-09 00:14:14 UTC) #76
Zachary Forman
https://codereview.chromium.org/1641413002/diff/240001/base/BUILD.gn File base/BUILD.gn (right): https://codereview.chromium.org/1641413002/diff/240001/base/BUILD.gn#newcode1894 base/BUILD.gn:1894: "//build/util/LASTCHANGE", On 2016/02/09 at 00:14:13, M-A Ruel wrote: > ...
4 years, 10 months ago (2016-02-09 00:47:19 UTC) #77
Dirk Pranke
On 2016/02/08 01:26:37, M-A Ruel wrote: > On 2016/02/06 17:39:01, Dirk Pranke wrote: > > ...
4 years, 10 months ago (2016-02-09 02:33:37 UTC) #78
Dirk Pranke
why did you go back to generating the header in the build? It seems much ...
4 years, 10 months ago (2016-02-09 02:46:56 UTC) #79
Zachary Forman
On 2016/02/09 at 02:46:56, dpranke wrote: > why did you go back to generating the ...
4 years, 10 months ago (2016-02-09 03:29:40 UTC) #80
M-A Ruel
lgtm pending win_disable_handle_verifier_hooks. I suspect it's a bad merge conflict. Thanks for getting this through! ...
4 years, 10 months ago (2016-02-09 13:57:06 UTC) #85
Dirk Pranke
I continue to think this approach is both overly complicated and not ideal. As I ...
4 years, 10 months ago (2016-02-09 19:38:03 UTC) #86
M-A Ruel
On 2016/02/09 19:38:03, Dirk Pranke wrote: > I continue to think this approach is both ...
4 years, 10 months ago (2016-02-09 19:47:41 UTC) #87
Dirk Pranke
On 2016/02/09 19:47:41, M-A Ruel wrote: > On 2016/02/09 19:38:03, Dirk Pranke wrote: > > ...
4 years, 10 months ago (2016-02-09 20:08:01 UTC) #88
M-A Ruel
On 2016/02/09 20:08:01, Dirk Pranke wrote: > On 2016/02/09 19:47:41, M-A Ruel wrote: > > ...
4 years, 10 months ago (2016-02-09 20:12:25 UTC) #89
Zachary Forman
Thanks very much for the rewrite of the CL description M-A, it looks great :) ...
4 years, 10 months ago (2016-02-09 20:57:35 UTC) #90
M-A Ruel
lgtm https://codereview.chromium.org/1641413002/diff/340001/build/write_build_date_header.py File build/write_build_date_header.py (right): https://codereview.chromium.org/1641413002/diff/340001/build/write_build_date_header.py#newcode52 build/write_build_date_header.py:52: return "{:%b %d %Y}".format(datetime.date(year, month, day)) single quote ...
4 years, 10 months ago (2016-02-09 21:00:59 UTC) #91
Zachary Forman
Fixed use of " + hit a few more that snuck in. https://codereview.chromium.org/1641413002/diff/340001/build/write_build_date_header.py File build/write_build_date_header.py ...
4 years, 10 months ago (2016-02-09 22:12:53 UTC) #92
M-A Ruel
lgtm
4 years, 10 months ago (2016-02-09 22:16:36 UTC) #93
Zachary Forman
agl, thakis: For owners approval, I need LGTMs from you. Could you please review, and ...
4 years, 10 months ago (2016-02-09 22:27:47 UTC) #94
agl
lgtm
4 years, 10 months ago (2016-02-09 22:45:12 UTC) #95
Nico
This is a nice compromise, lgtm except for the build/config/posix/BUILD.gn change which I don't understand ...
4 years, 10 months ago (2016-02-09 22:53:49 UTC) #96
Dirk Pranke
M-A and I discussed aspects of this off-CL, and agreed that if we were to ...
4 years, 10 months ago (2016-02-09 22:58:41 UTC) #97
Zachary Forman
Thanks for the comments - I especially like the method of inline testing of python. ...
4 years, 10 months ago (2016-02-09 23:26:23 UTC) #98
Nico
lgtm I'd consider landing this in three pieces: * the sysroot rebase bit * the ...
4 years, 10 months ago (2016-02-10 13:43:45 UTC) #99
Nico
(also, maybe you can update the timestamp bits on https://www.chromium.org/developers/testing/isolated-testing/deterministic-builds to explain how things work ...
4 years, 10 months ago (2016-02-10 17:30:11 UTC) #100
Zachary Forman
On 2016/02/10 at 17:30:11, thakis wrote: > (also, maybe you can update the timestamp bits ...
4 years, 10 months ago (2016-02-10 20:43:27 UTC) #101
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641413002/380001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641413002/380001
4 years, 10 months ago (2016-02-10 20:56:40 UTC) #104
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/143984)
4 years, 10 months ago (2016-02-11 02:10:07 UTC) #106
M-A Ruel
On 2016/02/11 02:10:07, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 10 months ago (2016-02-11 02:33:24 UTC) #107
Zachary Forman
On 2016/02/11 at 02:33:24, maruel wrote: > On 2016/02/11 02:10:07, commit-bot: I haz the power ...
4 years, 10 months ago (2016-02-11 02:40:21 UTC) #108
Zachary Forman
On 2016/02/11 at 02:40:21, Zachary Forman wrote: > On 2016/02/11 at 02:33:24, maruel wrote: > ...
4 years, 10 months ago (2016-02-11 03:45:51 UTC) #109
M-A Ruel
I tried to reproduce but got a surprising failure: E:\src\chromium\src>ninja -C out/Release mini_installer ninja: Entering ...
4 years, 10 months ago (2016-02-11 18:08:09 UTC) #110
Zachary Forman
On 2016/02/11 at 18:08:09, maruel wrote: > I tried to reproduce but got a surprising ...
4 years, 10 months ago (2016-02-11 20:03:18 UTC) #111
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641413002/380001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641413002/380001
4 years, 10 months ago (2016-02-12 02:58:17 UTC) #113
commit-bot: I haz the power
Committed patchset #20 (id:380001)
4 years, 10 months ago (2016-02-12 06:23:51 UTC) #115
Nico
this probably caused https://code.google.com/p/chromium/issues/detail?id=586702&thanks=586702&ts=1455331583
4 years, 10 months ago (2016-02-13 02:46:40 UTC) #116
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:42:04 UTC) #118
Message was sent while issue was closed.
Patchset 20 (id:??) landed as
https://crrev.com/08d91b75212b6592f05ff993d5a71c0f5a546563
Cr-Commit-Position: refs/heads/master@{#375136}

Powered by Google App Engine
This is Rietveld 408576698