Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1688)

Unified Diff: build/common.gypi

Issue 1641413002: Makes GetBuildTime behave identically on all build types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to #96 Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 4bc35cc4fda3995df770f7c983e58aef4223152c..17c0fc8e28cb4564ba4dfa941d7003a81395684a 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -379,10 +379,8 @@
'system_libdir%': '<(system_libdir)',
'order_profiling%': '<(order_profiling)',
- # Set to 1 to not store any build metadata, e.g. ifdef out all __DATE__
- # and __TIME__. Set to 0 to reenable the use of these macros in the code
- # base. See http://crbug.com/314403.
- 'dont_embed_build_metadata%': 1,
+ # TODO(zforman): Remove as soon as no bots depend on this.
+ 'dont_embed_build_metadata%': 0,
# Set to 1 to force Visual C++ to use legacy debug information format /Z7.
# This is useful for parallel compilation tools which can't support /Zi.
@@ -1174,7 +1172,6 @@
'enable_wifi_display%': '<(enable_wifi_display)',
'image_loader_extension%': '<(image_loader_extension)',
'fastbuild%': '<(fastbuild)',
- 'dont_embed_build_metadata%': '<(dont_embed_build_metadata)',
'win_z7%': '<(win_z7)',
'dcheck_always_on%': '<(dcheck_always_on)',
'tracing_like_official_build%': '<(tracing_like_official_build)',
@@ -1591,14 +1588,6 @@
'libjpeg_turbo_gyp_path': '<(DEPTH)/third_party/libjpeg_turbo/libjpeg.gyp',
'conditions': [
- ['buildtype=="Official"', {
- # Continue to embed build meta data in Official builds, basically the
- # time it was built.
- # TODO(maruel): This decision should be revisited because having an
- # official deterministic build has high value too but MSVC toolset can't
- # generate anything deterministic with WPO enabled AFAIK.
- 'dont_embed_build_metadata%': 0,
- }],
# Enable the Syzygy optimization step for the official builds.
['OS=="win" and buildtype=="Official" and syzyasan!=1 and clang!=1', {
'syzygy_optimize%': 1,
@@ -2848,11 +2837,6 @@
}],
],
}], # fastbuild!=0
- ['dont_embed_build_metadata==1', {
- 'defines': [
- 'DONT_EMBED_BUILD_METADATA',
- ],
- }], # dont_embed_build_metadata==1
['dcheck_always_on!=0', {
'defines': ['DCHECK_ALWAYS_ON=1'],
}], # dcheck_always_on!=0
« no previous file with comments | « base/build_time_unittest.cc ('k') | build/config/BUILD.gn » ('j') | build/config/posix/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698