Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Side by Side Diff: base/build_time.cc

Issue 1641413002: Makes GetBuildTime behave identically on all build types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Go back to gn/ninja solution. Remove instances of dont_use_build_metadata. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/build_time.h" 5 #include "base/build_time.h"
6 6
7 // Imports the generated build date, i.e. BUILD_DATE.
8 #include "base/generated_build_date.h"
9
7 #include "base/logging.h" 10 #include "base/logging.h"
8 #include "base/time/time.h" 11 #include "base/time/time.h"
9 12
10 namespace base { 13 namespace base {
11 14
12 Time GetBuildTime() { 15 Time GetBuildTime() {
13 Time integral_build_time; 16 Time integral_build_time;
14 // The format of __DATE__ and __TIME__ is specified by the ANSI C Standard, 17 // BUILD_DATE is exactly "Mmm DD YYYY".
15 // section 6.8.8. 18 const char kDateTime[] = BUILD_DATE " 05:00:00";
M-A Ruel 2016/02/09 00:14:13 Why 5?
Zachary Forman 2016/02/09 00:47:18 Arbitrary decision based on Thakis' suggestion of
16 // 19 bool result = Time::FromUTCString(kDateTime, &integral_build_time);
17 // __DATE__ is exactly "Mmm DD YYYY".
18 // __TIME__ is exactly "hh:mm:ss".
19 #if defined(DONT_EMBED_BUILD_METADATA) && !defined(OFFICIAL_BUILD)
20 const char kDateTime[] = "Sep 02 2008 08:00:00 PST";
21 #else
22 const char kDateTime[] = __DATE__ " " __TIME__ " PST";
23 #endif
24 bool result = Time::FromString(kDateTime, &integral_build_time);
25 DCHECK(result); 20 DCHECK(result);
26 return integral_build_time; 21 return integral_build_time;
27 } 22 }
28 23
29 } // namespace base 24 } // namespace base
OLDNEW
« base/build_time.h ('K') | « base/build_time.h ('k') | base/build_time_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698