Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1681833002: Removes dont_embed_build_metadata in preparation for its removal. (Closed)

Created:
4 years, 10 months ago by Zachary Forman
Modified:
4 years, 10 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, ghost stip (do not use), Sébastien Marchand
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Removes dont_embed_build_metadata in preparation for its removal. See https://codereview.chromium.org/1641413002 for details on why it can be removed in the near future. Should be applied at around the same time (slightly before is okay) 1641413002 is committed. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298725

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -20 lines) Patch
M scripts/slave/recipe_modules/chromium/config.py View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipes/deterministic_build.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/deterministic_build.expected/full_chromium_swarm_linux_deterministic.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/deterministic_build.expected/full_chromium_swarm_mac_deterministic.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/deterministic_build.expected/full_chromium_swarm_win_deterministic.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/swarming/deterministic_build.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Linux_deterministic.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Mac_deterministic.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Windows_Clang_deterministic.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Windows_deterministic.json View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Zachary Forman
Hi - small CL that just strips out dont_embed_build_metadata from the bots for when it's ...
4 years, 10 months ago (2016-02-09 03:17:31 UTC) #3
M-A Ruel
lgtm
4 years, 10 months ago (2016-02-09 13:32:19 UTC) #4
Sébastien Marchand
lgtm as well, thanks for taking care of this !
4 years, 10 months ago (2016-02-09 15:16:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1681833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1681833002/1
4 years, 10 months ago (2016-02-10 21:50:24 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 21:53:55 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298725

Powered by Google App Engine
This is Rietveld 408576698