Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: base/base.gyp

Issue 1641413002: Makes GetBuildTime behave identically on all build types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Go back to gn/ninja solution. Remove instances of dont_use_build_metadata. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'chromium_code': 1, 7 'chromium_code': 1,
8 }, 8 },
9 'includes': [ 9 'includes': [
10 '../build/win_precompile.gypi', 10 '../build/win_precompile.gypi',
11 'base.gypi', 11 'base.gypi',
12 ], 12 ],
13 'targets': [ 13 'targets': [
14 { 14 {
15 'target_name': 'base', 15 'target_name': 'base',
16 'type': '<(component)', 16 'type': '<(component)',
17 'toolsets': ['host', 'target'], 17 'toolsets': ['host', 'target'],
18 'variables': { 18 'variables': {
19 'base_target': 1, 19 'base_target': 1,
20 'enable_wexit_time_destructors': 1, 20 'enable_wexit_time_destructors': 1,
21 'optimize': 'max', 21 'optimize': 'max',
22 }, 22 },
23 'dependencies': [ 23 'dependencies': [
24 'allocator/allocator.gyp:allocator', 24 'allocator/allocator.gyp:allocator',
25 'base_debugging_flags#target', 25 'base_debugging_flags#target',
26 'base_static', 26 'base_static',
27 'base_build_date#target',
27 '../testing/gtest.gyp:gtest_prod', 28 '../testing/gtest.gyp:gtest_prod',
28 '../third_party/modp_b64/modp_b64.gyp:modp_b64', 29 '../third_party/modp_b64/modp_b64.gyp:modp_b64',
29 'third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotat ions', 30 'third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotat ions',
30 ], 31 ],
31 # TODO(gregoryd): direct_dependent_settings should be shared with the 32 # TODO(gregoryd): direct_dependent_settings should be shared with the
32 # 64-bit target, but it doesn't work due to a bug in gyp 33 # 64-bit target, but it doesn't work due to a bug in gyp
33 'direct_dependent_settings': { 34 'direct_dependent_settings': {
34 'include_dirs': [ 35 'include_dirs': [
35 '..', 36 '..',
36 ], 37 ],
(...skipping 948 matching lines...) Expand 10 before | Expand all | Expand 10 after
985 # toolchain, always refer to 'base_debugging_flags#target'. 986 # toolchain, always refer to 'base_debugging_flags#target'.
986 'target_name': 'base_debugging_flags', 987 'target_name': 'base_debugging_flags',
987 'includes': [ '../build/buildflag_header.gypi' ], 988 'includes': [ '../build/buildflag_header.gypi' ],
988 'variables': { 989 'variables': {
989 'buildflag_header_path': 'base/debug/debugging_flags.h', 990 'buildflag_header_path': 'base/debug/debugging_flags.h',
990 'buildflag_flags': [ 991 'buildflag_flags': [
991 'ENABLE_PROFILING=<(profiling)', 992 'ENABLE_PROFILING=<(profiling)',
992 ], 993 ],
993 }, 994 },
994 }, 995 },
996 {
997 'type': 'none',
998 'target_name': 'base_build_date',
999 'actions': [{
1000 'action_name': 'generate_build_date_headers',
1001 'inputs': [
1002 '<(DEPTH)/build/write_build_date_header.py',
1003 '<(DEPTH)/build/util/LASTCHANGE'
1004 ],
1005 'outputs': [ '<(SHARED_INTERMEDIATE_DIR)/base/generated_build_date.h' ],
1006 'action': [
1007 'python', '<(DEPTH)/build/write_build_date_header.py',
1008 '<(SHARED_INTERMEDIATE_DIR)/base/generated_build_date.h', '<(build_typ e)'
M-A Ruel 2016/02/09 00:14:13 wrap line
Zachary Forman 2016/02/09 00:47:18 Done
1009 ]
1010 }],
1011 'conditions': [
1012 [ 'buildtype == "Official"', {
1013 'variables': {
1014 'build_type': 'official'
1015 }
1016 }, {
1017 'variables': {
1018 'build_type': 'default'
1019 }
1020 }],
1021 ]
1022 },
995 ], 1023 ],
996 'conditions': [ 1024 'conditions': [
997 ['OS=="ios" and "<(GENERATOR)"=="ninja"', { 1025 ['OS=="ios" and "<(GENERATOR)"=="ninja"', {
998 'targets': [ 1026 'targets': [
999 { 1027 {
1000 'target_name': 'test_launcher', 1028 'target_name': 'test_launcher',
1001 'toolsets': ['host'], 1029 'toolsets': ['host'],
1002 'type': 'executable', 1030 'type': 'executable',
1003 'dependencies': [ 1031 'dependencies': [
1004 'test_support_base', 1032 'test_support_base',
(...skipping 633 matching lines...) Expand 10 before | Expand all | Expand 10 after
1638 '../build/isolate.gypi', 1666 '../build/isolate.gypi',
1639 ], 1667 ],
1640 'sources': [ 1668 'sources': [
1641 'base_unittests.isolate', 1669 'base_unittests.isolate',
1642 ], 1670 ],
1643 }, 1671 },
1644 ], 1672 ],
1645 }], 1673 }],
1646 ], 1674 ],
1647 } 1675 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698