Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: base/build_time.h

Issue 1641413002: Makes GetBuildTime behave identically on all build types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Follows rename. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_BUILD_TIME_H_ 5 #ifndef BASE_BUILD_TIME_H_
6 #define BASE_BUILD_TIME_H_ 6 #define BASE_BUILD_TIME_H_
7 7
8 #include "base/base_export.h" 8 #include "base/base_export.h"
9 #include "base/time/time.h" 9 #include "base/time/time.h"
10 10
11 namespace base { 11 namespace base {
12 12
13 // GetBuildTime returns the time at which the current binary was built. 13 // GetBuildTime returns the time at which the current binary was built,
14 // rounded to midnight at the start of the day.
agl 2016/01/29 21:46:45 s/rounded/rounded down/ (Normal rounding would su
M-A Ruel 2016/01/30 02:58:14 of the day in the current time zone, since __DATE_
Zachary Forman 2016/02/01 07:28:30 Done. I've adjusted it to use the result of a pyth
14 // 15 //
15 // This uses the __DATE__ and __TIME__ macros, which don't trigger a rebuild 16 // This uses the __DATE__ macro, which doesn't trigger a rebuild when it
16 // when they change. However, official builds will always be rebuilt from 17 // changes. However, official builds will always be built from scratch.
17 // scratch.
18 // 18 //
19 // Also, since __TIME__ doesn't include a timezone, this value should only be 19 // This value should only be considered accurate to a day.
agl 2016/01/29 21:46:46 s/a day/36 hours/ If you're just to the east of t
Zachary Forman 2016/02/01 07:28:30 Done. I've made it always use the real time at UTC
20 // considered accurate to a day.
21 //
22 // NOTE: This function is disabled except for the official builds, by default
23 // the date returned is "Sep 02 2008 08:00:00 PST".
24 Time BASE_EXPORT GetBuildTime(); 20 Time BASE_EXPORT GetBuildTime();
25 21
26 } // namespace base 22 } // namespace base
27 23
28 #endif // BASE_BUILD_TIME_H_ 24 #endif // BASE_BUILD_TIME_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698