Add the VMRS instruction to the integrated ARM assembler.

Add the VMRS instruction to the integrated ARM assembler.

Note: Only adds the APSR_nzcv register form of the instruction.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=ee7182759bc8e9acc9a8622e73ac315c4d2dd601

[Karl, 2016-01-25 16:11:25]

Description was changed from

==========
Add the VMRS instruction to the integrated ARM assembler.

Note: Only adds the APSR_nzcv register form of the instruction.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add the VMRS instruction to the integrated ARM assembler.

Note: Only adds the APSR_nzcv register form of the instruction.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

[Karl, 2016-01-25 16:11:25]

kschimpf@google.com changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, sehr@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2016-01-25 16:48:45]

lgtm

https://codereview.chromium.org/1636473002/diff/20001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/vmrs.ll (right):

https://codereview.chromium.org/1636473002/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/vmrs.ll:7: ; RUN:   -reg-use s20,s22,d20,d22 \
Do you need the -reg-use lines if you aren't testing for those register
encodings?

It's fine to leave those args if you have a general plan to use consistent
register sets across all tests.

[Karl, 2016-01-25 17:17:30]

Description was changed from

==========
Add the VMRS instruction to the integrated ARM assembler.

Note: Only adds the APSR_nzcv register form of the instruction.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add the VMRS instruction to the integrated ARM assembler.

Note: Only adds the APSR_nzcv register form of the instruction.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Karl, 2016-01-25 17:17:31]

Committed patchset #3 (id:40001) manually as
ee7182759bc8e9acc9a8622e73ac315c4d2dd601 (presubmit successful).

[Karl, 2016-01-25 17:17:44]

https://codereview.chromium.org/1636473002/diff/20001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/vmrs.ll (right):

https://codereview.chromium.org/1636473002/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/vmrs.ll:7: ; RUN:   -reg-use s20,s22,d20,d22 \
On 2016/01/25 16:48:45, stichnot wrote:
> Do you need the -reg-use lines if you aren't testing for those register
> encodings?
> 
> It's fine to leave those args if you have a general plan to use consistent
> register sets across all tests.

Good point. I forgot about the register argument when copying. Since the
instruction doesn't use any registers controlled by the register allocator,
removing the argument.