Replace HeapType with a non-templated FieldType class.

Replace HeapType with a non-templated FieldType class.

This replace HeapType with a dedicated class that implements just what we need for field type tracking. In the next CL, I plan to remove FieldType::Iterator because FieldType can iterate over at most one map.

The ultimate plan is to get rid of templates in types.(h|cc) and remove type-inl.h.

TBR=rossberg@chromium.org

Committed: https://crrev.com/cfaeb63b6825ef87e499b0c7beb09b475dcf5acc
Cr-Commit-Position: refs/heads/master@{#33521}

[Jarin, 2016-01-26 12:58:53]

Description was changed from

==========
Replace HeapType with a non-templated FieldType class.

BUG=
==========

to

==========
Replace HeapType with a non-templated FieldType class.

This replace HeapType with a dedicated class that implements just what we need
for field type tracking. In the next CL, I plan to remove FieldType::Iterator
because FieldType can iterate over at most one map.


The ultimate plan is to get rid of templates in types.(h|cc) and remove
type-inl.h.
==========

[Jarin, 2016-01-26 12:58:54]

jarin@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Jarin, 2016-01-26 12:59:36]

Could you take a look, please?

[Benedikt Meurer, 2016-01-26 14:22:47]

Kill it with fire! LGTM (feel free to defer/ignore comments)

https://codereview.chromium.org/1636013002/diff/40001/src/crankshaft/hydrogen...
File src/crankshaft/hydrogen-types.cc (right):

https://codereview.chromium.org/1636013002/diff/40001/src/crankshaft/hydrogen...
src/crankshaft/hydrogen-types.cc:31: HType
HType::FromFieldType(Handle<FieldType> type, Zone* temp_zone) {
Can we have a TODO here to remember to clean this up at some point? Maybe
involving some hard thinking.

https://codereview.chromium.org/1636013002/diff/40001/src/ic/arm/handler-comp...
File src/ic/arm/handler-compiler-arm.cc (right):

https://codereview.chromium.org/1636013002/diff/40001/src/ic/arm/handler-comp...
src/ic/arm/handler-compiler-arm.cc:405: FieldType::Iterator it =
field_type->Classes();
No Iterator please, assume there's only 0 or 1 map in the field type, and
simplify everything accordingly.

https://codereview.chromium.org/1636013002/diff/40001/src/ic/ia32/handler-com...
File src/ic/ia32/handler-compiler-ia32.cc (right):

https://codereview.chromium.org/1636013002/diff/40001/src/ic/ia32/handler-com...
src/ic/ia32/handler-compiler-ia32.cc:410: FieldType::Iterator it =
field_type->Classes();
Same here, no iterator pls.

https://codereview.chromium.org/1636013002/diff/40001/src/ic/ic.cc
File src/ic/ic.cc (right):

https://codereview.chromium.org/1636013002/diff/40001/src/ic/ic.cc#newcode1801
src/ic/ic.cc:1801: FieldType::Iterator it = field_type->Classes();
No Iterator please.

[Jarin, 2016-01-26 14:28:35]

The CQ bit was checked by jarin@chromium.org

[commit-bot: I haz the power, 2016-01-26 14:28:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1636013002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1636013002/40001

[Jarin, 2016-01-26 14:30:41]

https://codereview.chromium.org/1636013002/diff/40001/src/crankshaft/hydrogen...
File src/crankshaft/hydrogen-types.cc (right):

https://codereview.chromium.org/1636013002/diff/40001/src/crankshaft/hydrogen...
src/crankshaft/hydrogen-types.cc:31: HType
HType::FromFieldType(Handle<FieldType> type, Zone* temp_zone) {
On 2016/01/26 14:22:47, Benedikt Meurer wrote:
> Can we have a TODO here to remember to clean this up at some point? Maybe
> involving some hard thinking.

As discussed offline, it is not clear what can be cleaned here.

https://codereview.chromium.org/1636013002/diff/40001/src/ic/arm/handler-comp...
File src/ic/arm/handler-compiler-arm.cc (right):

https://codereview.chromium.org/1636013002/diff/40001/src/ic/arm/handler-comp...
src/ic/arm/handler-compiler-arm.cc:405: FieldType::Iterator it =
field_type->Classes();
On 2016/01/26 14:22:47, Benedikt Meurer wrote:
> No Iterator please, assume there's only 0 or 1 map in the field type, and
> simplify everything accordingly.

The Iterator will go away in the next CL.

[Jarin, 2016-01-26 14:32:29]

Description was changed from

==========
Replace HeapType with a non-templated FieldType class.

This replace HeapType with a dedicated class that implements just what we need
for field type tracking. In the next CL, I plan to remove FieldType::Iterator
because FieldType can iterate over at most one map.


The ultimate plan is to get rid of templates in types.(h|cc) and remove
type-inl.h.
==========

to

==========
Replace HeapType with a non-templated FieldType class.

This replace HeapType with a dedicated class that implements just what we need
for field type tracking. In the next CL, I plan to remove FieldType::Iterator
because FieldType can iterate over at most one map.


The ultimate plan is to get rid of templates in types.(h|cc) and remove
type-inl.h.

TBR=rossberg@chromium.org
==========

[commit-bot: I haz the power, 2016-01-26 15:03:44]

Description was changed from

==========
Replace HeapType with a non-templated FieldType class.

This replace HeapType with a dedicated class that implements just what we need
for field type tracking. In the next CL, I plan to remove FieldType::Iterator
because FieldType can iterate over at most one map.


The ultimate plan is to get rid of templates in types.(h|cc) and remove
type-inl.h.

TBR=rossberg@chromium.org
==========

to

==========
Replace HeapType with a non-templated FieldType class.

This replace HeapType with a dedicated class that implements just what we need
for field type tracking. In the next CL, I plan to remove FieldType::Iterator
because FieldType can iterate over at most one map.


The ultimate plan is to get rid of templates in types.(h|cc) and remove
type-inl.h.

TBR=rossberg@chromium.org
==========

[commit-bot: I haz the power, 2016-01-26 15:03:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-26 15:04:06]

Description was changed from

==========
Replace HeapType with a non-templated FieldType class.

This replace HeapType with a dedicated class that implements just what we need
for field type tracking. In the next CL, I plan to remove FieldType::Iterator
because FieldType can iterate over at most one map.


The ultimate plan is to get rid of templates in types.(h|cc) and remove
type-inl.h.

TBR=rossberg@chromium.org
==========

to

==========
Replace HeapType with a non-templated FieldType class.

This replace HeapType with a dedicated class that implements just what we need
for field type tracking. In the next CL, I plan to remove FieldType::Iterator
because FieldType can iterate over at most one map.

The ultimate plan is to get rid of templates in types.(h|cc) and remove
type-inl.h.

TBR=rossberg@chromium.org

Committed: https://crrev.com/cfaeb63b6825ef87e499b0c7beb09b475dcf5acc
Cr-Commit-Position: refs/heads/master@{#33521}
==========

[commit-bot: I haz the power, 2016-01-26 15:04:07]

Patchset 3 (id:??) landed as
https://crrev.com/cfaeb63b6825ef87e499b0c7beb09b475dcf5acc
Cr-Commit-Position: refs/heads/master@{#33521}