Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Unified Diff: src/ic/handler-compiler.cc

Issue 1636013002: Replace HeapType with a non-templated FieldType class. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix tracing of generalizations Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ic/handler-compiler.cc
diff --git a/src/ic/handler-compiler.cc b/src/ic/handler-compiler.cc
index a523a1945b3c5bd2372de98bfb6b1c4d7ead2618..5c4299e5409728e7d9ca5051018409752a4ae6f3 100644
--- a/src/ic/handler-compiler.cc
+++ b/src/ic/handler-compiler.cc
@@ -509,9 +509,8 @@ Handle<Code> NamedStoreHandlerCompiler::CompileStoreTransition(
return GetCode(kind(), Code::FAST, name);
}
-
bool NamedStoreHandlerCompiler::RequiresFieldTypeChecks(
- HeapType* field_type) const {
+ FieldType* field_type) const {
return !field_type->Classes().Done();
}
@@ -520,7 +519,7 @@ Handle<Code> NamedStoreHandlerCompiler::CompileStoreField(LookupIterator* it) {
Label miss;
DCHECK(it->representation().IsHeapObject());
- HeapType* field_type = *it->GetFieldType();
+ FieldType* field_type = *it->GetFieldType();
bool need_save_restore = false;
if (RequiresFieldTypeChecks(field_type)) {
need_save_restore = IC::ICUseVector(kind());

Powered by Google App Engine
This is Rietveld 408576698