test/cctest/heap/test-heap.cc - Issue 1636013002: Replace HeapType with a non-templated FieldType class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/heap/test-heap.cc

Issue 1636013002: Replace HeapType with a non-templated FieldType class. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix tracing of generalizations Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/heap/test-heap.cc

diff --git a/test/cctest/heap/test-heap.cc b/test/cctest/heap/test-heap.cc

index 577675f0a1e7a69805d52fe765c81b88189f66b3..6df355d289d30ad8168c3030b5812cb234126808 100644

--- a/test/cctest/heap/test-heap.cc

+++ b/test/cctest/heap/test-heap.cc

@@ -5656,8 +5656,9 @@ TEST(Regress388880) {

Handle<Map> map1 = Map::Create(isolate, 1);

Handle<Map> map2 =

Map::CopyWithField(map1, factory->NewStringFromStaticChars("foo"),

- HeapType::Any(isolate), NONE, Representation::Tagged(),

- OMIT_TRANSITION).ToHandleChecked();

+ FieldType::Any(isolate), NONE,

+ Representation::Tagged(), OMIT_TRANSITION)

+ .ToHandleChecked();

int desired_offset = Page::kPageSize - map1->instance_size();