src/crankshaft/hydrogen.h - Issue 1636013002: Replace HeapType with a non-templated FieldType class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/hydrogen.h

Issue 1636013002: Replace HeapType with a non-templated FieldType class. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix tracing of generalizations Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/hydrogen.h

diff --git a/src/crankshaft/hydrogen.h b/src/crankshaft/hydrogen.h

index 0a08402fc61e210161c9b5a2cfb56088f04c78a9..46bd1d4b1d56800d072325ea0a00b9bc8bd89623 100644

--- a/src/crankshaft/hydrogen.h

+++ b/src/crankshaft/hydrogen.h

@@ -2644,7 +2644,7 @@ class HOptimizedGraphBuilder : public HGraphBuilder, public AstVisitor {

Handle<Object> GetAccessorsFromMap(Handle<Map> map) const {

return GetConstantFromMap(map);

}

- Handle<HeapType> GetFieldTypeFromMap(Handle<Map> map) const {

+ Handle<FieldType> GetFieldTypeFromMap(Handle<Map> map) const {

DCHECK(IsFound());

DCHECK(number_ < map->NumberOfOwnDescriptors());

return handle(map->instance_descriptors()->GetFieldType(number_),