Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: src/lookup.cc

Issue 1636013002: Replace HeapType with a non-templated FieldType class. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix tracing of generalizations Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« src/ic/ic.cc ('K') | « src/lookup.h ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/lookup.h" 5 #include "src/lookup.h"
6 6
7 #include "src/bootstrapper.h" 7 #include "src/bootstrapper.h"
8 #include "src/deoptimizer.h" 8 #include "src/deoptimizer.h"
9 #include "src/elements.h" 9 #include "src/elements.h"
10 #include "src/isolate-inl.h" 10 #include "src/isolate-inl.h"
(...skipping 458 matching lines...) Expand 10 before | Expand all | Expand 10 after
469 DCHECK(has_property_); 469 DCHECK(has_property_);
470 DCHECK(!holder_map_->is_dictionary_map()); 470 DCHECK(!holder_map_->is_dictionary_map());
471 DCHECK_EQ(v8::internal::DATA, property_details_.type()); 471 DCHECK_EQ(v8::internal::DATA, property_details_.type());
472 DCHECK(!IsElement()); 472 DCHECK(!IsElement());
473 int index = 473 int index =
474 holder_map_->instance_descriptors()->GetFieldIndex(descriptor_number()); 474 holder_map_->instance_descriptors()->GetFieldIndex(descriptor_number());
475 bool is_double = representation().IsDouble(); 475 bool is_double = representation().IsDouble();
476 return FieldIndex::ForPropertyIndex(*holder_map_, index, is_double); 476 return FieldIndex::ForPropertyIndex(*holder_map_, index, is_double);
477 } 477 }
478 478
479 479 Handle<FieldType> LookupIterator::GetFieldType() const {
480 Handle<HeapType> LookupIterator::GetFieldType() const {
481 DCHECK(has_property_); 480 DCHECK(has_property_);
482 DCHECK(!holder_map_->is_dictionary_map()); 481 DCHECK(!holder_map_->is_dictionary_map());
483 DCHECK_EQ(v8::internal::DATA, property_details_.type()); 482 DCHECK_EQ(v8::internal::DATA, property_details_.type());
484 return handle( 483 return handle(
485 holder_map_->instance_descriptors()->GetFieldType(descriptor_number()), 484 holder_map_->instance_descriptors()->GetFieldType(descriptor_number()),
486 isolate_); 485 isolate_);
487 } 486 }
488 487
489 488
490 Handle<PropertyCell> LookupIterator::GetPropertyCell() const { 489 Handle<PropertyCell> LookupIterator::GetPropertyCell() const {
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
711 // Fall through. 710 // Fall through.
712 default: 711 default:
713 return NOT_FOUND; 712 return NOT_FOUND;
714 } 713 }
715 UNREACHABLE(); 714 UNREACHABLE();
716 return state_; 715 return state_;
717 } 716 }
718 717
719 } // namespace internal 718 } // namespace internal
720 } // namespace v8 719 } // namespace v8
OLDNEW
« src/ic/ic.cc ('K') | « src/lookup.h ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698