[DevTools] Remove InspectorState.

[DevTools] Remove InspectorState.

Instead of serializing state on every change, we serialize it before
sending the message response, thus removing need for callback.
This may affect performance in positive or negative way, but it's not
a hot path.

BUG=580337
Committed: https://crrev.com/bc1a5c04a5cc60467d1d57179f8b01d902e46854
Cr-Commit-Position: refs/heads/master@{#371433}

[dgozman, 2016-01-23 02:26:44]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2016-01-23 02:26:45]

Take a look please.

[pfeldman, 2016-01-25 18:22:54]

I am not sure I like the extended syntax. Should we introduce

bool asBoolean(name, defaultValue) in JSONValue to mitigate it?

Also I am not a huge fan of this conceptually. The state is essentially an
opaque object (a string) and maintaining a simpler (key/value) API for such a
state made more sense that exposing hierarchical objects of general nature.

https://codereview.chromium.org/1621923002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorBaseAgent.cpp (right):

https://codereview.chromium.org/1621923002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorBaseAgent.cpp:63: bool
InspectorAgent::getBooleanState(const String& propertyName) const
booleanState? (no get prefixes in non-out-param getters in Blink)

[dgozman, 2016-01-25 19:25:42]

PTAL

[pfeldman, 2016-01-25 20:19:06]

https://codereview.chromium.org/1621923002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1621923002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp:224:
m_state->setNumber(DebuggerAgentState::pauseOnExceptionsState,
(long)V8DebuggerImpl::DontPauseOnExceptions);
static_cast

https://codereview.chromium.org/1621923002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp:227:
m_state->setNumber(DebuggerAgentState::asyncCallStackDepth, (long)0);
static_cast

https://codereview.chromium.org/1621923002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp:305: String
skipStackPattern;
Can we do anything about this getting twice as big?

https://codereview.chromium.org/1621923002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/JSONValues.cpp (right):

https://codereview.chromium.org/1621923002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/JSONValues.cpp:375: bool
JSONObjectBase::getBoolean(const String& name, bool defaultValue) const
We should not mess with naming conventions - this form returns value in the
output param.

[dgozman, 2016-01-26 01:16:54]

PTAL

https://codereview.chromium.org/1621923002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1621923002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp:224:
m_state->setNumber(DebuggerAgentState::pauseOnExceptionsState,
(long)V8DebuggerImpl::DontPauseOnExceptions);
On 2016/01/25 20:19:06, pfeldman wrote:
> static_cast

Done.

https://codereview.chromium.org/1621923002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp:227:
m_state->setNumber(DebuggerAgentState::asyncCallStackDepth, (long)0);
On 2016/01/25 20:19:06, pfeldman wrote:
> static_cast

Done.

https://codereview.chromium.org/1621923002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp:305: String
skipStackPattern;
On 2016/01/25 20:19:06, pfeldman wrote:
> Can we do anything about this getting twice as big?

Reduced with booleanProperty.

https://codereview.chromium.org/1621923002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/JSONValues.cpp (right):

https://codereview.chromium.org/1621923002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/JSONValues.cpp:375: bool
JSONObjectBase::getBoolean(const String& name, bool defaultValue) const
On 2016/01/25 20:19:06, pfeldman wrote:
> We should not mess with naming conventions - this form returns value in the
> output param.

Renamed to booleanProperty.

[pfeldman, 2016-01-26 01:18:32]

lgtm

[dgozman, 2016-01-26 01:19:08]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-01-26 01:22:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1621923002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1621923002/80001

[commit-bot: I haz the power, 2016-01-26 02:58:00]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-01-26 02:58:57]

Description was changed from

==========
[DevTools] Remove InspectorState.

Instead of serializing state on every change, we serialize it before
sending the message response, thus removing need for callback.
This may affect performance in positive or negative way, but it's not
a hot path.

BUG=580337
==========

to

==========
[DevTools] Remove InspectorState.

Instead of serializing state on every change, we serialize it before
sending the message response, thus removing need for callback.
This may affect performance in positive or negative way, but it's not
a hot path.

BUG=580337

Committed: https://crrev.com/bc1a5c04a5cc60467d1d57179f8b01d902e46854
Cr-Commit-Position: refs/heads/master@{#371433}
==========

[commit-bot: I haz the power, 2016-01-26 02:58:58]

Patchset 5 (id:??) landed as
https://crrev.com/bc1a5c04a5cc60467d1d57179f8b01d902e46854
Cr-Commit-Position: refs/heads/master@{#371433}